From: Wojciech Drewek <wojciech.drewek@intel•com>
To: Kurt Kanzenbach <kurt@linutronix•de>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
"shenjian (K)" <shenjian15@huawei•com>,
Simon Horman <horms@kernel•org>,
Vinicius Costa Gomes <vinicius.gomes@intel•com>,
<intel-wired-lan@lists•osuosl.org>, <netdev@vger•kernel.org>
Subject: Re: [PATCH iwl-next v3] igc: Add MQPRIO offload support
Date: Fri, 21 Jun 2024 12:41:35 +0200 [thread overview]
Message-ID: <76a0974f-9f49-4b80-ba7c-0ec00b237592@intel.com> (raw)
In-Reply-To: <20240212-igc_mqprio-v3-1-261f5bb99a2a@linutronix.de>
On 21.06.2024 09:25, Kurt Kanzenbach wrote:
> Add support for offloading MQPRIO. The hardware has four priorities as well
> as four queues. Each queue must be a assigned with a unique priority.
>
> However, the priorities are only considered in TSN Tx mode. There are two
> TSN Tx modes. In case of MQPRIO the Qbv capability is not required.
> Therefore, use the legacy TSN Tx mode, which performs strict priority
> arbitration.
>
> Example for mqprio with hardware offload:
>
> |tc qdisc replace dev ${INTERFACE} handle 100 parent root mqprio num_tc 4 \
> | map 0 0 0 0 0 1 2 3 0 0 0 0 0 0 0 0 \
> | queues 1@0 1@1 1@2 1@3 \
> | hw 1
>
> The mqprio Qdisc also allows to configure the `preemptible_tcs'. However,
> frame preemption is not supported yet.
>
> Tested on Intel i225 and implemented by following data sheet section 7.5.2,
> Transmit Scheduling.
>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix•de>
> ---
Thank you!
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel•com>
> Changes in v3:
> - Use FIELD_PREP for Tx ARB (Simon)
> - Add helper for Tx ARB configuration (Simon)
> - Limit ethtool_set_channels when mqprio is enabled (Jian)
> - Link to v2: https://lore.kernel.org/r/20240212-igc_mqprio-v2-1-587924e6b18c@linutronix.de
>
> Changes in v2:
> - Improve changelog (Paul Menzel)
> - Link to v1: https://lore.kernel.org/r/20240212-igc_mqprio-v1-1-7aed95b736db@linutronix.de
> ---
> drivers/net/ethernet/intel/igc/igc.h | 10 +++-
> drivers/net/ethernet/intel/igc/igc_defines.h | 11 +++++
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 4 ++
> drivers/net/ethernet/intel/igc/igc_main.c | 69 +++++++++++++++++++++++++++
> drivers/net/ethernet/intel/igc/igc_regs.h | 2 +
> drivers/net/ethernet/intel/igc/igc_tsn.c | 70 +++++++++++++++++++++++++++-
> 6 files changed, 163 insertions(+), 3 deletions(-)
>
<...>
next prev parent reply other threads:[~2024-06-21 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 7:25 [PATCH iwl-next v3] igc: Add MQPRIO offload support Kurt Kanzenbach
2024-06-21 10:41 ` Wojciech Drewek [this message]
2024-06-27 0:02 ` Vinicius Costa Gomes
2024-07-01 7:15 ` Simon Horman
2024-07-23 7:30 ` [Intel-wired-lan] " Mor Bar-Gabay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76a0974f-9f49-4b80-ba7c-0ec00b237592@intel.com \
--to=wojciech.drewek@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=bigeasy@linutronix$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kurt@linutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shenjian15@huawei$(echo .)com \
--cc=vinicius.gomes@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox