From: Kevin Hilman <khilman@linaro•org>
To: Sekhar Nori <nsekhar@ti•com>
Cc: David Miller <davem@davemloft•net>,
Linux DaVinci Mailing List
<davinci-linux-open-source@linux•davincidsp.com>,
Linux netdev Mailing List <netdev@vger•kernel.org>,
Prabhakar Lad <prabhakar.csengg@gmail•com>,
Mugunthan V N <mugunthanvnm@ti•com>
Subject: Re: [PATCH] net: davinci_emac: fix oops caused by uninitialized ndev->dev
Date: Wed, 21 May 2014 16:39:40 -0700 [thread overview]
Message-ID: <7h8upuog5f.fsf@paris.lan> (raw)
In-Reply-To: <1400580697-24994-1-git-send-email-nsekhar@ti.com> (Sekhar Nori's message of "Tue, 20 May 2014 15:41:37 +0530")
Sekhar Nori <nsekhar@ti•com> writes:
> Commit e194312854edc22a2faf1931b3c0608fe20cb969 (drivers: net:
> davinci_cpdma: Convert kzalloc() to devm_kzalloc()) triggered
> a bug in emac_probe() wherein dev member of net_device is used
> for devres allocations even before it is initialized.
>
> This patch fixes that by using the struct device in platform_device
> instead.
>
> While at it, use &pdev->dev consistently for console messages instead
> of using ndev->dev for just one case and remove an unnecessary line
> continuation.
>
> Reported-by: Kevin Hilman <khilman@linaro•org>
> Helped-by: George Cherian <george.cherian@ti•com>
> Signed-off-by: Sekhar Nori <nsekhar@ti•com>
Tested-by: Kevin Hilman <khilman@linaro•org>
I verified this patch fixes the boot on dm365-evm (legacy boot) and
da850-evm (DT boot).
Thanks,
Kevin
next prev parent reply other threads:[~2014-05-21 23:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 10:11 [PATCH] net: davinci_emac: fix oops caused by uninitialized ndev->dev Sekhar Nori
2014-05-20 10:14 ` Mugunthan V N
2014-05-20 16:46 ` Prabhakar Lad
2014-05-21 23:39 ` Kevin Hilman [this message]
2014-05-22 19:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h8upuog5f.fsf@paris.lan \
--to=khilman@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=davinci-linux-open-source@linux$(echo .)davincidsp.com \
--cc=mugunthanvnm@ti$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nsekhar@ti$(echo .)com \
--cc=prabhakar.csengg@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox