From: Kevin Hilman <khilman@baylibre•com>
To: Parvathi Pudi <parvathi@couthit•com>,
nm@ti•com, vigneshr@ti•com, afd@ti•com, rogerq@kernel•org,
tony@atomide•com, robh@kernel•org, krzk+dt@kernel•org,
conor+dt@kernel•org, richardcochran@gmail•com,
aaro.koskinen@iki•fi, andreas@kemnade•info
Cc: andrew@lunn•ch, linux-omap@vger•kernel.org,
devicetree@vger•kernel.org, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, danishanwar@ti•com, pratheesh@ti•com,
j-rameshbabu@ti•com, praneeth@ti•com, srk@ti•com, rogerq@ti•com,
m-malladi@ti•com, krishna@couthit•com, mohan@couthit•com,
pmohan@couthit•com, basharath@couthit•com, parvathi@couthit•com,
Murali Karicheri <m-karicheri2@ti•com>
Subject: Re: [PATCH v5 3/3] arm: dts: ti: Add device tree support for PRU-ICSS on AM335x
Date: Thu, 12 Mar 2026 17:59:15 -0700 [thread overview]
Message-ID: <7ho6ks1r4s.fsf@baylibre.com> (raw)
In-Reply-To: <20260307122641.738450-4-parvathi@couthit.com>
Parvathi Pudi <parvathi@couthit•com> writes:
> From: Roger Quadros <rogerq@ti•com>
>
> The TI Sitara AM335x ICE-V2 consists of single PRU-ICSS instance,
> This patch adds the new device tree overlay file in-order to enable
> PRU-ICSS instance, along with makefile changes.
>
> PRU-ICSS instance consists of two PRU cores along with various
> peripherals such as the Interrupt Controller (PRU_INTC), the Industrial
> Ethernet Peripheral(IEP), the Real Time Media Independent Interface
> controller (MII_RT), and the Enhanced Capture (eCAP) event module.
>
> am33xx-l4.dtsi - Adds IEP and eCAP peripheral as child nodes
> of the PRUSS subsystem node.
>
> am335x-icev2-prueth.dtso - Adds PRU-ICSS instance node along with PRU
> eth port information and corresponding port configuration. It includes
> interrupt mapping for packet reception, HW timestamp collection, and PRU
> Ethernet ports in MII mode,
>
> GPIO configuration, boot strapping along with delay configuration for
> individual PRU Ethernet port and other required nodes.
>
> Signed-off-by: Roger Quadros <rogerq@ti•com>
> Signed-off-by: Andrew F. Davis <afd@ti•com>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti•com>
> Signed-off-by: Basharath Hussain Khaja <basharath@couthit•com>
> Signed-off-by: Parvathi Pudi <parvathi@couthit•com>
[...]
> +/*
> + * Disable CPSW switch node and
> + * MDIO configuration to prevent
> + * conflict with PRU-ICSS
> + */
> +&mac_sw {
> + status = "disable";
> +};
> +
> +&davinci_mdio_sw {
> + status = "disable";
> +};
I think you need s/disable/disabled/? (note the trailing 'd'). Without
that, I don't think you're disabling these nodes, so I'm curious how it
is not conflicting with the PRU-ICSS.
Kevin
next prev parent reply other threads:[~2026-03-13 0:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 12:23 [PATCH v5 0/3] Add support for ICSSM Ethernet on AM57x, AM437x, and AM335x Parvathi Pudi
2026-03-07 12:23 ` [PATCH v5 1/3] arm: dts: ti: Add device tree support for PRU-ICSS on AM57xx Parvathi Pudi
2026-03-07 12:23 ` [PATCH v5 2/3] arm: dts: ti: Add device tree support for PRU-ICSS on AM437x Parvathi Pudi
2026-03-07 12:23 ` [PATCH v5 3/3] arm: dts: ti: Add device tree support for PRU-ICSS on AM335x Parvathi Pudi
2026-03-13 0:59 ` Kevin Hilman [this message]
2026-03-16 12:00 ` Parvathi Pudi
2026-03-16 18:13 ` Kevin Hilman
2026-03-24 5:58 ` Parvathi Pudi
2026-03-16 18:52 ` Krzysztof Kozlowski
2026-03-24 6:02 ` Parvathi Pudi
2026-03-24 12:38 ` Andrew Lunn
2026-03-30 12:22 ` Parvathi Pudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ho6ks1r4s.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=aaro.koskinen@iki$(echo .)fi \
--cc=afd@ti$(echo .)com \
--cc=andreas@kemnade$(echo .)info \
--cc=andrew@lunn$(echo .)ch \
--cc=basharath@couthit$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=danishanwar@ti$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=j-rameshbabu@ti$(echo .)com \
--cc=krishna@couthit$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=m-karicheri2@ti$(echo .)com \
--cc=m-malladi@ti$(echo .)com \
--cc=mohan@couthit$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nm@ti$(echo .)com \
--cc=parvathi@couthit$(echo .)com \
--cc=pmohan@couthit$(echo .)com \
--cc=praneeth@ti$(echo .)com \
--cc=pratheesh@ti$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=rogerq@kernel$(echo .)org \
--cc=rogerq@ti$(echo .)com \
--cc=srk@ti$(echo .)com \
--cc=tony@atomide$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox