From: Florian Fainelli <f.fainelli@gmail•com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux•com>,
netdev@vger•kernel.org
Cc: linux-kernel@vger•kernel.org, kernel@savoirfairelinux•com,
"David S. Miller" <davem@davemloft•net>,
Andrew Lunn <andrew@lunn•ch>
Subject: Re: [PATCH net-next 0/4] net: dsa: move master ethtool code
Date: Tue, 19 Sep 2017 13:04:56 -0700 [thread overview]
Message-ID: <80b8afa0-e269-c0b7-da4a-dcb604a239ca@gmail.com> (raw)
In-Reply-To: <20170919155700.14474-1-vivien.didelot@savoirfairelinux.com>
On 09/19/2017 08:56 AM, Vivien Didelot wrote:
> The DSA core overrides the master device's ethtool_ops structure so that
> it can inject statistics and such of its dedicated switch CPU port.
>
> This ethtool code is currently called on unnecessary conditions or
> before the master interface and its switch CPU port get wired up.
> This patchset fixes this.
>
> Similarly to slave.c where the DSA slave net_device is the entry point
> of the dsa_slave_* functions, this patchset also isolates the master's
> ethtool code in a new master.c file, where the DSA master net_device is
> the entry point of the dsa_master_* functions.
>
> This is a first step towards better control of the master device and
> support for multiple CPU ports.
Tested-by: Florian Fainelli <f.fainelli@gmail•com>
* ethtool -S eth0 -> switch port CPU stats are still correctly overlayed
* ethtool -s gphy wol g -> both switch port and CPU port correctly
enable WoL
* ethtool -i eth0 -> driver still reports correct information
Thanks!
>
> Vivien Didelot (4):
> net: dsa: remove copy of master ethtool_ops
> net: dsa: setup master ethtool unconditionally
> net: dsa: setup master ethtool after dsa_ptr
> net: dsa: move master ethtool code
>
> include/net/dsa.h | 1 -
> net/dsa/Makefile | 2 +-
> net/dsa/dsa.c | 28 -------------
> net/dsa/dsa2.c | 18 ++++----
> net/dsa/dsa_priv.h | 7 ++--
> net/dsa/legacy.c | 10 ++---
> net/dsa/master.c | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> net/dsa/slave.c | 80 -----------------------------------
> 8 files changed, 136 insertions(+), 130 deletions(-)
> create mode 100644 net/dsa/master.c
>
--
Florian
next prev parent reply other threads:[~2017-09-19 20:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 15:56 [PATCH net-next 0/4] net: dsa: move master ethtool code Vivien Didelot
2017-09-19 15:56 ` [PATCH net-next 1/4] net: dsa: remove copy of master ethtool_ops Vivien Didelot
2017-09-19 19:55 ` Florian Fainelli
2017-09-19 15:56 ` [PATCH net-next 2/4] net: dsa: setup master ethtool unconditionally Vivien Didelot
2017-09-19 17:48 ` Florian Fainelli
2017-09-19 15:56 ` [PATCH net-next 3/4] net: dsa: setup master ethtool after dsa_ptr Vivien Didelot
2017-09-19 17:49 ` Florian Fainelli
2017-09-19 15:57 ` [PATCH net-next 4/4] net: dsa: move master ethtool code Vivien Didelot
2017-09-19 19:56 ` Florian Fainelli
2017-09-19 20:04 ` Florian Fainelli [this message]
2017-09-19 23:04 ` [PATCH net-next 0/4] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80b8afa0-e269-c0b7-da4a-dcb604a239ca@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=kernel@savoirfairelinux$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox