From: Roman Mashak <mrv@mojatatu•com>
To: Davide Caratti <dcaratti@redhat•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, kernel@mojatatu•com,
jhs@mojatatu•com, xiyou.wangcong@gmail•com, jiri@resnulli•us
Subject: Re: [PATCH net 1/5] net sched actions: fix coding style in pedit action
Date: Wed, 20 Jun 2018 09:25:37 -0400 [thread overview]
Message-ID: <851sd1fv3i.fsf@mojatatu.com> (raw)
In-Reply-To: <fccb4f8c0e3070c289c4c110786ac7071f4e61cf.camel@redhat.com> (Davide Caratti's message of "Wed, 20 Jun 2018 14:29:43 +0200")
Davide Caratti <dcaratti@redhat•com> writes:
> On Tue, 2018-06-19 at 12:56 -0400, Roman Mashak wrote:
>> Fix coding style issues in tc pedit action detected by the
>> checkpatch script.
>>
>> Signed-off-by: Roman Mashak <mrv@mojatatu•com>
> ...
>
>> ---
>> @@ -316,16 +318,15 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
>> hoffset + tkey->at);
>> goto bad;
>> }
>> - d = skb_header_pointer(skb, hoffset + tkey->at, 1,
>> - &_d);
>> + d = skb_header_pointer(skb, hoffset + tkey->at,
>> + 1, &_d);
>> if (!d)
>> goto bad;
>> offset += (*d & tkey->offmask) >> tkey->shift;
>> }
>
> hello Roman,
>
> nit: while we are here, what about changing the declaration of _d and *d
> to u8, so that the bitwise operation is done on unsigned?
Yes makes sense, I will send v2 in net-next once opened. Thanks Davide.
> BTW: the patch (and the series) looks ok, but I guess it will better
> target net-next when the branch reopens
next prev parent reply other threads:[~2018-06-20 13:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 16:56 [PATCH net 0/5] net sched actions: code style cleanup and fixes Roman Mashak
2018-06-19 16:56 ` [PATCH net 1/5] net sched actions: fix coding style in pedit action Roman Mashak
2018-06-20 12:29 ` Davide Caratti
2018-06-20 13:25 ` Roman Mashak [this message]
2018-06-19 16:56 ` [PATCH net 2/5] net sched actions: fix coding style in pedit headers Roman Mashak
2018-06-19 16:56 ` [PATCH net 3/5] net sched actions: fix sparse warning Roman Mashak
2018-06-19 16:56 ` [PATCH net 4/5] net sched actions: use sizeof operator for buffer length Roman Mashak
2018-06-19 16:56 ` [PATCH net 5/5] net sched actions: fix misleading text strings in pedit action Roman Mashak
2018-06-19 17:04 ` Stephen Hemminger
2018-06-19 17:15 ` Roman Mashak
2018-06-20 8:20 ` [PATCH net 0/5] net sched actions: code style cleanup and fixes Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=851sd1fv3i.fsf@mojatatu.com \
--to=mrv@mojatatu$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dcaratti@redhat$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kernel@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox