Subject: Re: [PATCH net-next 1/6] selftests: qdiscs: Add TDC test for RED

From: Roman Mashak <[email-masked]>
Date: Tue, 10 Mar 2020 11:40:00 -0400

Ido Schimmel <[email-masked]> writes:

> From: Petr Machata <[email-masked]>
>
> Add a handful of tests for creating RED with different flags.
>

Thanks for adding new tests in TDC.

Could you give more descriptive names for tests? (Look at
tc-tests/qdiscs/fifo.json or tc-tests/qdiscs/ets.json as examples)

Did you try running this with nsPlugin enabled? I think you would need
to add the following for every test:

"plugins": {
        "requires": "nsPlugin"
}

> Signed-off-by: Petr Machata <[email-masked]>
> Signed-off-by: Ido Schimmel <[email-masked]>
> ---
>  .../tc-testing/tc-tests/qdiscs/red.json       | 102 ++++++++++++++++++
>  1 file changed, 102 insertions(+)
>  create mode 100644 tools/testing/selftests/tc-testing/tc-tests/qdiscs/red.json
>
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/red.json b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/red.json
> new file mode 100644
> index 000000000000..6c5a4c4e0a45
> --- /dev/null
> +++ b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/red.json
> @@ -0,0 +1,102 @@
> +[
> +    {
> +        "id": "8b6e",
> +        "name": "RED",
> +        "category": [
> +            "qdisc",
> +            "red"
> +        ],
> +        "setup": [
> +            "$IP link add dev $DUMMY type dummy || /bin/true"
> +        ],
> +        "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root red limit 1M avpkt 1500 min 100K max 300K",
> +        "expExitCode": "0",
> +        "verifyCmd": "$TC qdisc show dev $DUMMY",
> +        "matchPattern": "qdisc red 1: root .* limit 1Mb min 100Kb max 300Kb",
> +        "matchCount": "1",
> +        "teardown": [
> +            "$TC qdisc del dev $DUMMY handle 1: root",
> +            "$IP link del dev $DUMMY type dummy"
> +        ]
> +    },

[...]