From: Roman Mashak <mrv@mojatatu•com>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: dsahern@gmail•com, netdev@vger•kernel.org, kernel@mojatatu•com,
jhs@mojatatu•com, xiyou.wangcong@gmail•com, jiri@resnulli•us,
Jiri Pirko <jiri@mellanox•com>
Subject: Re: [PATCH iproute2 1/1] tc: action: fix time values output in JSON format
Date: Tue, 19 May 2020 18:09:38 -0400 [thread overview]
Message-ID: <85lflnmva5.fsf@mojatatu.com> (raw)
In-Reply-To: <20200519142925.282bf732@hermes.lan> (Stephen Hemminger's message of "Tue, 19 May 2020 14:29:25 -0700")
Stephen Hemminger <stephen@networkplumber•org> writes:
> On Mon, 18 May 2020 13:29:18 -0400
> Roman Mashak <mrv@mojatatu•com> wrote:
>
>> Report tcf_t values in seconds, not jiffies, in JSON format as it is now
>> for stdout.
>>
>> Fixes: 2704bd625583 ("tc: jsonify actions core")
>> Cc: Jiri Pirko <jiri@mellanox•com>
>> Signed-off-by: Roman Mashak <mrv@mojatatu•com>
>> ---
>> tc/tc_util.c | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/tc/tc_util.c b/tc/tc_util.c
>> index 12f865cc71bf..118e19da35bb 100644
>> --- a/tc/tc_util.c
>> +++ b/tc/tc_util.c
>> @@ -751,17 +751,20 @@ void print_tm(FILE *f, const struct tcf_t *tm)
>> int hz = get_user_hz();
>>
>> if (tm->install != 0) {
>> - print_uint(PRINT_JSON, "installed", NULL, tm->install);
>> + print_uint(PRINT_JSON, "installed", NULL,
>> + (unsigned int)(tm->install/hz));
>> print_uint(PRINT_FP, NULL, " installed %u sec",
>> (unsigned int)(tm->install/hz));
>> }
>
> Please use PRINT_ANY, drop the useless casts and fix the style.
>
Thanks Stephen. I will send v2.
> diff --git a/tc/tc_util.c b/tc/tc_util.c
> index 12f865cc71bf..fd5fcb242b64 100644
> --- a/tc/tc_util.c
> +++ b/tc/tc_util.c
> @@ -750,21 +750,17 @@ void print_tm(FILE *f, const struct tcf_t *tm)
> {
> int hz = get_user_hz();
[...]
prev parent reply other threads:[~2020-05-19 22:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 17:29 [PATCH iproute2 1/1] tc: action: fix time values output in JSON format Roman Mashak
2020-05-19 21:29 ` Stephen Hemminger
2020-05-19 22:09 ` Roman Mashak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85lflnmva5.fsf@mojatatu.com \
--to=mrv@mojatatu$(echo .)com \
--cc=dsahern@gmail$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kernel@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox