Subject: Re: [PATCH iproute2 v2 1/1] vxlan: Add support for modifying vxlan device attributes

From: Roman Mashak <[email-masked]>
Date: Sun, 07 May 2017 10:40:29 -0400

Girish Moodalbail <[email-masked]> writes:

[...]

>  ip/iplink_vxlan.c | 251 +++++++++++++++++++++++++++++++-----------------------
>  1 file changed, 143 insertions(+), 108 deletions(-)
>
> diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
> index b4ebb13..2bd619d 100644
> --- a/ip/iplink_vxlan.c
> +++ b/ip/iplink_vxlan.c
> @@ -21,6 +21,8 @@
>  #include "utils.h"
>  #include "ip_common.h"
>  
> +#define VXLAN_ATTRSET(attrs, type) (((attrs) & (1L << (type))) != 0)

I think you can drop '!= 0' part in the macro.

[...]

>  
> +static void check_duparg(__u64 *attrs, int type, const char *key,
> +			 const char *argv)
> +{
> +	if (!VXLAN_ATTRSET(*attrs, type)) {
> +		*attrs |= (1L << type);
> +		return;
> +	}
> +	duparg2(key, argv);
> +}

[...]