From: Roman Mashak <mrv@mojatatu•com>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: netdev@vger•kernel.org, jhs@mojatatu•com,
xiyou.wangcong@gmail•com, jiri@resnulli•us
Subject: Re: [PATCH v3 iproute2 1/1] tc: fix conversion types when printing actions unsigned values
Date: Tue, 27 Mar 2018 17:33:05 -0400 [thread overview]
Message-ID: <85tvt1i4q6.fsf@mojatatu.com> (raw)
In-Reply-To: <20180327090234.5d457806@xeon-e3> (Stephen Hemminger's message of "Tue, 27 Mar 2018 09:02:34 -0700")
Stephen Hemminger <stephen@networkplumber•org> writes:
> On Mon, 19 Mar 2018 17:05:41 -0400
> Roman Mashak <mrv@mojatatu•com> wrote:
>
>> diff --git a/tc/m_gact.c b/tc/m_gact.c
>> index 16c4413f4217..52022415db48 100644
>> --- a/tc/m_gact.c
>> +++ b/tc/m_gact.c
>> @@ -194,7 +194,7 @@ print_gact(struct action_util *au, FILE *f, struct rtattr *arg)
>> print_string(PRINT_ANY, "random_type", "\n\t random type %s",
>> prob_n2a(pp->ptype));
>> print_action_control(f, " ", pp->paction, " ");
>> - print_int(PRINT_ANY, "val", "val %d", pp->pval);
>> + print_int(PRINT_ANY, "val", "val %u", pp->pval);
>> close_json_object();
>
> This needs to be print_uint in order to work correctly with json output.
>
> Also, please consider doing json on all the match types in a later patch
> for net-next.
Did you mean iproute2-next?
next prev parent reply other threads:[~2018-03-27 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 21:05 [PATCH v3 iproute2 1/1] tc: fix conversion types when printing actions unsigned values Roman Mashak
2018-03-27 16:02 ` Stephen Hemminger
2018-03-27 21:33 ` Roman Mashak [this message]
2018-03-27 21:56 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85tvt1i4q6.fsf@mojatatu.com \
--to=mrv@mojatatu$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox