Subject: Re: [PATCH net-next 1/1] net sched actions: rename act_get_notify() to tcf_get_notify()

From: Roman Mashak <[email-masked]>
Date: Wed, 05 Jul 2017 17:13:32 -0400

Jiri Pirko <[email-masked]> writes:

> Wed, Jul 05, 2017 at 09:33:58PM CEST, [email-masked] wrote:
>>Make name consistent with other TC event notification routines.
>>
>>Signed-off-by: Roman Mashak <[email-masked]>
>>---
>> net/sched/act_api.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>>diff --git a/net/sched/act_api.c b/net/sched/act_api.c
>>index aed6cf2..f2e9ed3 100644
>>--- a/net/sched/act_api.c
>>+++ b/net/sched/act_api.c
>>@@ -835,7 +835,7 @@ static int tca_get_fill(struct sk_buff *skb, struct list_head *actions,
>> }
>> 
>> static int
>>-act_get_notify(struct net *net, u32 portid, struct nlmsghdr *n,
>>+tcf_get_notify(struct net *net, u32 portid, struct nlmsghdr *n,
>
> Rather call it "tcf_action_get_notify"

We already have tcf_add_notify() and tcf_del_notify() as a common style.

>
> + net-next is closed if I'm not mistaken