From: Florian Fainelli <f.fainelli@gmail•com>
To: Linus Walleij <linus.walleij@linaro•org>,
Andrew Lunn <andrew@lunn•ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux•com>,
Woojung Huh <Woojung.Huh@microchip•com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip•com>
Cc: netdev@vger•kernel.org, openwrt-devel@lists•openwrt.org,
LEDE Development List <lede-dev@lists•infradead.org>,
Gabor Juhos <juhosg@openwrt•org>
Subject: Re: [PATCH 2/3] net: phy: vitesse: Add support for VSC73xx
Date: Thu, 14 Jun 2018 09:29:32 -0700 [thread overview]
Message-ID: <87156f76-449c-1ec3-e7fa-776c2fddc992@gmail.com> (raw)
In-Reply-To: <20180614123534.8063-3-linus.walleij@linaro.org>
On 06/14/2018 05:35 AM, Linus Walleij wrote:
> The VSC7385, VSC7388, VSC7395 and VSC7398 are integrated
> switch/router chips for 5+1 or 8-port switches/routers. When
> managed directly by Linux using DSA we need to do a special
> set-up "dance" on the PHY. Unfortunately these sequences
> switches the PHY to undocumented pages named 2a30 and 52b6
> and does undocumented things. It is described by these opaque
> sequences also in the reference manual. This is a best
> effort to integrate it anyways.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro•org>
Probably as good as it can get given the information you have access to.
Maybe the guys at Mircochip could help, adding them.
Reviewed-by: Florian Fainelli <f.fainelli@gmail•com>
Just one nit below:
> ---
> drivers/net/phy/vitesse.c | 162 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 162 insertions(+)
>
> diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c
> index d9dd8fbfffc7..526c71ae7d96 100644
> --- a/drivers/net/phy/vitesse.c
> +++ b/drivers/net/phy/vitesse.c
> @@ -16,6 +16,7 @@
> #include <linux/module.h>
> #include <linux/mii.h>
> #include <linux/ethtool.h>
> +#include <linux/delay.h>
Is that needed?
--
Florian
next prev parent reply other threads:[~2018-06-14 16:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 12:35 [PATCH 0/3] DSA driver for Vitesse VSC73xx Linus Walleij
2018-06-14 12:35 ` [PATCH 1/3] net: dsa: Add DT bindings for Vitesse VSC73xx switches Linus Walleij
2018-06-14 16:09 ` Florian Fainelli
2018-06-14 16:09 ` Florian Fainelli
2018-06-17 7:40 ` Jiri Pirko
2018-06-14 12:35 ` [PATCH 2/3] net: phy: vitesse: Add support for VSC73xx Linus Walleij
2018-06-14 16:29 ` Florian Fainelli [this message]
2018-06-15 19:24 ` Woojung.Huh
2018-06-28 18:23 ` Linus Walleij
2018-06-14 12:35 ` [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver Linus Walleij
2018-06-14 16:51 ` Florian Fainelli
2018-06-30 11:05 ` Linus Walleij
2018-06-30 11:05 ` Linus Walleij
2019-03-03 12:08 ` Vladimir Oltean
2019-03-04 9:51 ` Linus Walleij
2019-03-04 12:14 ` Vladimir Oltean
2019-03-04 12:26 ` Linus Walleij
2019-03-04 13:53 ` Andrew Lunn
2019-03-04 14:10 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87156f76-449c-1ec3-e7fa-776c2fddc992@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=Woojung.Huh@microchip$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=juhosg@openwrt$(echo .)org \
--cc=lede-dev@lists$(echo .)infradead.org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=openwrt-devel@lists$(echo .)openwrt.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox