Subject: Re: [PATCH net-next v2 09/12] selftests: drv-net: add a Python version of the GRO test

From: Petr Machata <[email-masked]>
Date: Wed, 19 Nov 2025 16:54:45 +0100

Jakub Kicinski <[email-masked]> writes:

> Rewrite the existing gro.sh test in Python. The conversion
> not exact, the changes are related to integrating the test
> with our "remote endpoint" paradigm. The test now reads
> the IP addresses from the user config. It resolves the MAC
> address (including running over Layer 3 networks).
>
> Signed-off-by: Jakub Kicinski <[email-masked]>

Reviewed-by: Petr Machata <[email-masked]>

However:

> +    base_cmd_args = [
> +        f"--{protocol}",
> +        f"--dmac {_resolve_dmac(cfg, ipver)}",
> +        f"--smac {cfg.remote_dev['address']}",
> +        f"--daddr {cfg.addr_v[ipver]}",
> +        f"--saddr {cfg.remote_addr_v[ipver]}",
> +        f"--test {test_name}",
> +        "--verbose"
> +    ]
> +    base_args = " ".join(base_cmd_args)
> +

> +    max_retries = 6
> +    for attempt in range(max_retries):

The original had a comment about flakiness which was IMHO useful. The
"retry failures" paradigm on its own is transparent enough, but the
comment explained why the flakiness comes up.

2c