From: Rahul Rameshbabu <rrameshbabu@nvidia•com>
To: Mateusz Polchlopek <mateusz.polchlopek@intel•com>
Cc: intel-wired-lan@lists•osuosl.org, netdev@vger•kernel.org,
horms@kernel•org, anthony.l.nguyen@intel•com,
Jacob Keller <jacob.e.keller@intel•com>,
Wojciech Drewek <wojciech.drewek@intel•com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 04/12] iavf: add support for negotiating flexible RXDID format
Date: Thu, 18 Apr 2024 12:11:01 -0700 [thread overview]
Message-ID: <871q72fpn8.fsf@nvidia.com> (raw)
In-Reply-To: <20240418052500.50678-5-mateusz.polchlopek@intel.com>
On Thu, 18 Apr, 2024 01:24:52 -0400 Mateusz Polchlopek <mateusz.polchlopek@intel•com> wrote:
> From: Jacob Keller <jacob.e.keller@intel•com>
>
> Enable support for VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC, to enable the VF
> driver the ability to determine what Rx descriptor formats are
> available. This requires sending an additional message during
> initialization and reset, the VIRTCHNL_OP_GET_SUPPORTED_RXDIDS. This
> operation requests the supported Rx descriptor IDs available from the
> PF.
>
> This is treated the same way that VLAN V2 capabilities are handled. Add
> a new set of extended capability flags, used to process send and receipt
> of the VIRTCHNL_OP_GET_SUPPORTED_RXDIDS message.
>
> This ensures we finish negotiating for the supported descriptor formats
> prior to beginning configuration of receive queues.
>
> This change stores the supported format bitmap into the iavf_adapter
> structure. Additionally, if VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC is enabled
> by the PF, we need to make sure that the Rx queue configuration
> specifies the format.
>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel•com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel•com>
> Co-developed-by: Mateusz Polchlopek <mateusz.polchlopek@intel•com>
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@intel•com>
> ---
<snip>
> @@ -2586,6 +2623,67 @@ static void iavf_init_recv_offload_vlan_v2_caps(struct iavf_adapter *adapter)
> iavf_change_state(adapter, __IAVF_INIT_FAILED);
> }
>
> +/**
> + * iavf_init_send_supported_rxdids - part of querying for supported RXDID
> + * formats
> + * @adapter: board private structure
> + *
> + * Function processes send of the request for supported RXDIDs to the PF.
> + * Must clear IAVF_EXTENDED_CAP_RECV_RXDID if the message is not sent, e.g.
> + * due to the PF not negotiating VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC.
> + */
> +static void iavf_init_send_supported_rxdids(struct iavf_adapter *adapter)
> +{
> + int ret;
> +
> + WARN_ON(!(adapter->extended_caps & IAVF_EXTENDED_CAP_SEND_RXDID));
> +
> + ret = iavf_send_vf_supported_rxdids_msg(adapter);
> + if (ret && ret == -EOPNOTSUPP) {
Isn't this redundant? The condition can just be "ret == -EOPNOTSUPP"?
> + /* PF does not support VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC. In this
> + * case, we did not send the capability exchange message and
> + * do not expect a response.
> + */
> + adapter->extended_caps &= ~IAVF_EXTENDED_CAP_RECV_RXDID;
> + }
> +
> + /* We sent the message, so move on to the next step */
> + adapter->extended_caps &= ~IAVF_EXTENDED_CAP_SEND_RXDID;
> +}
> +
<snip>
--
Thanks,
Rahul Rameshbabu
next prev parent reply other threads:[~2024-04-18 19:15 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 5:24 [Intel-wired-lan] [PATCH iwl-next v5 00/12] Add support for Rx timestamping for both ice and iavf drivers Mateusz Polchlopek
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 01/12] virtchnl: add support for enabling PTP on iAVF Mateusz Polchlopek
2024-04-18 18:49 ` Rahul Rameshbabu
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 02/12] ice: support Rx timestamp on flex descriptor Mateusz Polchlopek
2024-04-18 18:57 ` Rahul Rameshbabu
2024-04-22 9:34 ` Mateusz Polchlopek
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 03/12] virtchnl: add enumeration for the rxdid format Mateusz Polchlopek
2024-04-18 19:05 ` Rahul Rameshbabu
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 04/12] iavf: add support for negotiating flexible RXDID format Mateusz Polchlopek
2024-04-18 19:11 ` Rahul Rameshbabu [this message]
2024-04-22 9:34 ` Mateusz Polchlopek
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 05/12] iavf: negotiate PTP capabilities Mateusz Polchlopek
2024-04-18 19:16 ` Rahul Rameshbabu
2024-04-22 9:33 ` Mateusz Polchlopek
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 06/12] iavf: add initial framework for registering PTP clock Mateusz Polchlopek
2024-04-18 19:28 ` Rahul Rameshbabu
2024-04-22 9:29 ` Mateusz Polchlopek
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 07/12] iavf: add support for indirect access to PHC time Mateusz Polchlopek
2024-04-18 19:43 ` Rahul Rameshbabu
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 08/12] iavf: periodically cache " Mateusz Polchlopek
2024-04-18 19:51 ` Rahul Rameshbabu
2024-04-22 9:23 ` Mateusz Polchlopek
2024-04-24 22:03 ` Keller, Jacob E
2024-04-25 10:52 ` Przemek Kitszel
2024-04-25 16:28 ` Keller, Jacob E
2024-04-25 17:10 ` Rahul Rameshbabu
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 09/12] iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors Mateusz Polchlopek
2024-04-18 20:00 ` Rahul Rameshbabu
2024-04-22 9:22 ` Mateusz Polchlopek
2024-04-23 10:51 ` Sunil Kovvuri Goutham
2024-04-26 7:15 ` Mateusz Polchlopek
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 10/12] iavf: Implement checking DD desc field Mateusz Polchlopek
2024-04-18 20:07 ` Rahul Rameshbabu
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 11/12] iavf: handle SIOCSHWTSTAMP and SIOCGHWTSTAMP Mateusz Polchlopek
2024-04-18 20:08 ` Rahul Rameshbabu
2024-04-18 5:25 ` [Intel-wired-lan] [PATCH iwl-next v5 12/12] iavf: add support for Rx timestamps to hotpath Mateusz Polchlopek
2024-04-18 20:12 ` Rahul Rameshbabu
2024-04-23 10:47 ` Sunil Kovvuri Goutham
2024-04-18 20:19 ` [Intel-wired-lan] [PATCH iwl-next v5 00/12] Add support for Rx timestamping for both ice and iavf drivers Rahul Rameshbabu
2024-04-22 9:37 ` Mateusz Polchlopek
2024-04-23 5:57 ` Rahul Rameshbabu
2024-04-23 6:08 ` Mateusz Polchlopek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q72fpn8.fsf@nvidia.com \
--to=rrameshbabu@nvidia$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=mateusz.polchlopek@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wojciech.drewek@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox