Subject: RE: [PATCH iwl-next,v4 1/1] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

From: Vinicius Costa Gomes <[email-masked]>
Date: Tue, 26 Mar 2024 11:30:27 -0700

"Song, Yoong Siang" <[email-masked]> writes:

>>
>>More a question: you are potentially triggering an interrupt from
>>igc_ptp_clear_tx_tstamp() (igc_xsk_wakeup()) which can be called from
>>igc_down(). So, how does it work when there's a pending timestamp and
>>you remove the igc module? (example of a situation that it might be
>>problematic).
>
> Hi Vinicius,
>
> Thanks for reviewing the patch.
>
> There is test_bit(__IGC_DOWN, &adapter->state) checking in
> igc_sxk_wakeup(). Since igc_down() will set __IGC_DOWN before
> call into igc_ptp_suspend(), so I believe the checking in igc_sxk_wakeup()
> should be enough to prevent the situation that you mentioned.
>

Oh, I missed that one, sorry. Then:

Acked-by: Vinicius Costa Gomes <[email-masked]>

Cheers,
-- 
Vinicius