From: Tobias Waldekranz <tobias@waldekranz•com>
To: Rob Herring <robh@kernel•org>
Cc: davem@davemloft•net, kuba@kernel•org, netdev@vger•kernel.org,
Andrew Lunn <andrew@lunn•ch>,
Madalin Bucur <madalin.bucur@nxp•com>,
devicetree@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2 net 2/4] dt-bindings: net: Document fsl,erratum-a009885
Date: Fri, 21 Jan 2022 13:30:17 +0100 [thread overview]
Message-ID: <871r11cluu.fsf@waldekranz.com> (raw)
In-Reply-To: <YeoVlBEWWlqDf7NG@robh.at.kernel.org>
On Thu, Jan 20, 2022 at 20:08, Rob Herring <robh@kernel•org> wrote:
> On Tue, Jan 18, 2022 at 10:50:51PM +0100, Tobias Waldekranz wrote:
>> Update FMan binding documentation with the newly added workaround for
>> erratum A-009885.
>>
>> Signed-off-by: Tobias Waldekranz <tobias@waldekranz•com>
>> Reviewed-by: Andrew Lunn <andrew@lunn•ch>
>> ---
>> Documentation/devicetree/bindings/net/fsl-fman.txt | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/fsl-fman.txt b/Documentation/devicetree/bindings/net/fsl-fman.txt
>> index c00fb0d22c7b..020337f3c05f 100644
>> --- a/Documentation/devicetree/bindings/net/fsl-fman.txt
>> +++ b/Documentation/devicetree/bindings/net/fsl-fman.txt
>> @@ -410,6 +410,15 @@ PROPERTIES
>> The settings and programming routines for internal/external
>> MDIO are different. Must be included for internal MDIO.
>>
>> +- fsl,erratum-a009885
>
> Adding errata properties doesn't work because then you have to update
> your dtb to fix the issue where as if you use the compatible property
> (specific to the SoC) you can fix the issue with just a (stable) kernel
> update.
>
> Yes, I see we already have some, but doesn't mean we need more of them.
I agree. Unfortunately all users of the driver also use the same
compatible string, so there was no way I could think of that would not
involve rebuilding DTBs anyway. Given that situation, I chose to just
extend what was already there.
next prev parent reply other threads:[~2022-01-21 12:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 21:50 [PATCH v2 net 0/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885 Tobias Waldekranz
2022-01-18 21:50 ` [PATCH v2 net 1/4] " Tobias Waldekranz
2022-01-18 21:50 ` [PATCH v2 net 2/4] dt-bindings: net: Document fsl,erratum-a009885 Tobias Waldekranz
2022-01-21 2:08 ` Rob Herring
2022-01-21 12:30 ` Tobias Waldekranz [this message]
2022-01-18 21:50 ` [PATCH v2 net 3/4] powerpc/fsl/dts: Enable WA for erratum A-009885 on fman3l MDIO buses Tobias Waldekranz
2022-01-18 21:50 ` [PATCH v2 net 4/4] net/fsl: xgmac_mdio: Fix incorrect iounmap when removing module Tobias Waldekranz
2022-01-19 16:30 ` [PATCH v2 net 0/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r11cluu.fsf@waldekranz.com \
--to=tobias@waldekranz$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=madalin.bucur@nxp$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robh@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox