From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Ido Schimmel <idosch@idosch•org>, netdev@vger•kernel.org
Cc: davem@davemloft•net, kuba@kernel•org, jiri@nvidia•com,
petrm@nvidia•com, liuhangbin@gmail•com, mlxsw@nvidia•com,
Ido Schimmel <idosch@nvidia•com>
Subject: Re: [PATCH net 1/2] mlxsw: spectrum: Fix ECN marking in tunnel decapsulation
Date: Mon, 29 Mar 2021 11:03:17 +0200 [thread overview]
Message-ID: <871rby9vsa.fsf@toke.dk> (raw)
In-Reply-To: <20210329082927.347631-2-idosch@idosch.org>
Ido Schimmel <idosch@idosch•org> writes:
> From: Ido Schimmel <idosch@nvidia•com>
>
> Cited commit changed the behavior of the software data path with regards
> to the ECN marking of decapsulated packets. However, the commit did not
> change other callers of __INET_ECN_decapsulate(), namely mlxsw. The
> driver is using the function in order to ensure that the hardware and
> software data paths act the same with regards to the ECN marking of
> decapsulated packets.
>
> The discrepancy was uncovered by commit 5aa3c334a449 ("selftests:
> forwarding: vxlan_bridge_1d: Fix vxlan ecn decapsulate value") that
> aligned the selftest to the new behavior. Without this patch the
> selftest passes when used with veth pairs, but fails when used with
> mlxsw netdevs.
>
> Fix this by instructing the device to propagate the ECT(1) mark from the
> outer header to the inner header when the inner header is ECT(0), for
> both NVE and IP-in-IP tunnels.
>
> A helper is added in order not to duplicate the code between both tunnel
> types.
>
> Fixes: b723748750ec ("tunnel: Propagate ECT(1) when decapsulating as recommended by RFC6040")
> Signed-off-by: Ido Schimmel <idosch@nvidia•com>
> Reviewed-by: Petr Machata <petrm@nvidia•com>
Huh, I had no idea there was a caller in the driver - thanks for fixing
that!
Acked-by: Toke Høiland-Jørgensen <toke@redhat•com>
next prev parent reply other threads:[~2021-03-29 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 8:29 [PATCH net 0/2] mlxsw: spectrum: Fix ECN marking in tunnel decapsulation Ido Schimmel
2021-03-29 8:29 ` [PATCH net 1/2] " Ido Schimmel
2021-03-29 9:03 ` Toke Høiland-Jørgensen [this message]
2021-03-29 8:29 ` [PATCH net 2/2] selftests: forwarding: vxlan_bridge_1d: Add more ECN decap test cases Ido Schimmel
2021-03-29 9:03 ` Toke Høiland-Jørgensen
2021-03-29 8:29 ` [PATCH net mlxsw v2 0/2] mlxsw: spectrum: Fix ECN marking in tunnel decapsulation Ido Schimmel
2021-03-29 8:38 ` Ido Schimmel
2021-03-29 8:29 ` [PATCH net mlxsw v2 1/2] " Ido Schimmel
2021-03-29 8:29 ` [PATCH net mlxsw v2 2/2] selftests: forwarding: vxlan_bridge_1d: Add more ECN decap test cases Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rby9vsa.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=idosch@idosch$(echo .)org \
--cc=idosch@nvidia$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=liuhangbin@gmail$(echo .)com \
--cc=mlxsw@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=petrm@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox