From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Jesper Dangaard Brouer <brouer@redhat•com>
Cc: "David Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, "Daniel Borkmann" <daniel@iogearbox•net>,
"Alexei Starovoitov" <ast@kernel•org>,
"Jakub Kicinski" <jakub.kicinski@netronome•com>,
BjörnTöpel <bjorn.topel@gmail•com>,
brouer@redhat•com
Subject: Re: [PATCH net-next v4 4/6] xdp: Always use a devmap for XDP_REDIRECT to a device
Date: Tue, 09 Apr 2019 11:23:28 +0200 [thread overview]
Message-ID: <871s2bzg4v.fsf@toke.dk> (raw)
In-Reply-To: <20190409102559.28cbb37a@carbon>
Jesper Dangaard Brouer <brouer@redhat•com> writes:
> On Mon, 08 Apr 2019 19:05:56 +0200 Toke Høiland-Jørgensen <toke@redhat•com> wrote:
>
>> +void dev_map_put_default_map(struct net *net)
>> +{
>> + mutex_lock(&dev_map_mtx);
>
> Looks like a white-space error...
>
>> + if (atomic_dec_and_test(&net->xdp.default_map.use_cnt)) {
>> + __dev_map_release_default_map(&net->xdp.default_map);
>> + }
>> + mutex_unlock(&dev_map_mtx);
>
> And here again.
Yeah, and there are more :/
Will fix, thanks!
-Toke
next prev parent reply other threads:[~2019-04-09 9:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 17:05 [PATCH net-next v4 0/6] xdp: Use a default map for xdp_redirect helper Toke Høiland-Jørgensen
2019-04-08 17:05 ` [PATCH net-next v4 3/6] xdp: Refactor devmap code in preparation for subsequent additions Toke Høiland-Jørgensen
2019-04-08 17:05 ` [PATCH net-next v4 2/6] net: xdp: remove XDP_QUERY_PROG Toke Høiland-Jørgensen
2019-04-08 17:05 ` [PATCH net-next v4 1/6] net: xdp: refactor XDP attach Toke Høiland-Jørgensen
2019-04-08 20:23 ` Daniel Borkmann
2019-05-09 10:40 ` Björn Töpel
2019-04-09 12:54 ` kbuild test robot
2019-04-08 17:05 ` [PATCH net-next v4 4/6] xdp: Always use a devmap for XDP_REDIRECT to a device Toke Høiland-Jørgensen
2019-04-09 8:25 ` Jesper Dangaard Brouer
2019-04-09 9:23 ` Toke Høiland-Jørgensen [this message]
2019-04-10 7:59 ` [xdp] 9cb54e254c: kernel/bpf/devmap.c:#suspicious_rcu_dereference_check() kernel test robot
2019-04-10 10:00 ` Toke Høiland-Jørgensen
2019-04-08 17:05 ` [PATCH net-next v4 5/6] xdp: Add devmap_idx map type for looking up devices by ifindex Toke Høiland-Jørgensen
2019-04-08 17:05 ` [PATCH net-next v4 6/6] selftests/bpf: Add test for default devmap allocation Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s2bzg4v.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bjorn.topel@gmail$(echo .)com \
--cc=brouer@redhat$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox