From: Rusty Russell <rusty@rustcorp•com.au>
To: "Michał Mirosław" <mirq-linux@rere•qmqm.pl>, netdev@vger•kernel.org
Subject: Re: [PATCH] net: tun: convert to hw_features
Date: Wed, 20 Apr 2011 12:52:24 +0930 [thread overview]
Message-ID: <871v0xip3j.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20110419161310.7508513909@rere.qmqm.pl>
On Tue, 19 Apr 2011 18:13:10 +0200 (CEST), Michał Mirosław <mirq-linux@rere•qmqm.pl> wrote:
> This changes offload setting behaviour to what I think is correct:
> - offloads set via ethtool mean what admin wants to use (by default
> he wants 'em all)
> - offloads set via ioctl() mean what userspace is expecting to get
> (this limits which admin wishes are granted)
> - TUN_NOCHECKSUM is ignored, as it might cause broken packets when
> forwarded (ip_summed == CHECKSUM_UNNECESSARY means that checksum
> was verified, not that it can be ignored)
>
> If TUN_NOCHECKSUM is implemented, it should set skb->csum_* and
> skb->ip_summed (= CHECKSUM_PARTIAL) for known protocols and let others
> be verified by kernel when necessary.
>
> TUN_NOCHECKSUM handling was introduced by commit
> f43798c27684ab925adde7d8acc34c78c6e50df8:
>
> tun: Allow GSO using virtio_net_hdr
Err, not in my git tree! It predates git in fact.
Since tap requires privs, I wouldn't worry about invalid packets too
much.
Thanks,
Rusty.
next prev parent reply other threads:[~2011-04-20 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 16:13 [PATCH] net: tun: convert to hw_features Michał Mirosław
2011-04-20 3:22 ` Rusty Russell [this message]
2011-04-20 23:15 ` Michał Mirosław
2011-04-20 8:32 ` David Miller
2011-04-27 4:59 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871v0xip3j.fsf@rustcorp.com.au \
--to=rusty@rustcorp$(echo .)com.au \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox