Subject: Re: [PATCH iwl-net v3] igb: Fix not clearing TimeSync interrupts for 82580

From: Vinicius Costa Gomes <[email-masked]>
Date: Thu, 15 Aug 2024 18:07:40 -0700

Daiwei Li <[email-masked]> writes:

> 82580 NICs have a hardware bug that makes it
> necessary to write into the TSICR (TimeSync Interrupt Cause) register
> to clear it:
> https://lore.kernel.org/all/[email-masked]/
>
> Add a conditional so only for 82580 we write into the TSICR register,
> so we don't risk losing events for other models.
>
> Without this change, when running ptp4l with an Intel 82580 card,
> I get the following output:
>
>> timed out while polling for tx timestamp increasing tx_timestamp_timeout or
>> increasing kworker priority may correct this issue, but a driver bug likely
>> causes it
>
> This goes away with this change.
>
> This (partially) reverts commit ee14cc9ea19b ("igb: Fix missing time sync events").
>
> Fixes: ee14cc9ea19b ("igb: Fix missing time sync events")
> Closes: https://lore.kernel.org/intel-wired-lan/CAN0jFd1kO0MMtOh8N2Ztxn6f7vvDKp2h507sMryobkBKe=xk=[email-masked]/
> Tested-by: Daiwei Li <[email-masked]>
> Suggested-by: Vinicius Costa Gomes <[email-masked]>
> Signed-off-by: Daiwei Li <[email-masked]>

Acked-by: Vinicius Costa Gomes <[email-masked]>

Cheers,
-- 
Vinicius