From: Kurt Kanzenbach <kurt@kmk-computers•de>
To: Andrew Lunn <andrew@lunn•ch>
Cc: Vivien Didelot <vivien.didelot@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Vladimir Oltean <olteanv@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next] net: dsa: hellcreek: Report switch name and ID
Date: Mon, 22 Mar 2021 19:41:23 +0100 [thread overview]
Message-ID: <8735wnf2uk.fsf@kmk-computers.de> (raw)
In-Reply-To: <YFYFLiwnXBeXhqgj@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 884 bytes --]
On Sat Mar 20 2021, Andrew Lunn wrote:
>> +static int hellcreek_devlink_info_get(struct dsa_switch *ds,
>> + struct devlink_info_req *req,
>> + struct netlink_ext_ack *extack)
>> +{
>> + struct hellcreek *hellcreek = ds->priv;
>> + int ret;
>> +
>> + ret = devlink_info_driver_name_put(req, "hellcreek");
>> + if (ret)
>> + return ret;
>> +
>> + return devlink_info_version_fixed_put(req,
>> + DEVLINK_INFO_VERSION_GENERIC_ASIC_ID,
>> + hellcreek->pdata->name);
>
>> static const struct hellcreek_platform_data de1soc_r1_pdata = {
>> + .name = "Hellcreek r4c30",
>
> Hi Kurt
>
> The two other DSA drivers which implement this keep the
> DEVLINK_INFO_VERSION_GENERIC_ASIC_ID just the model name, mv88e6390,
> SJA1105E for example. You have hellcreek in the driver name, so i
> don't see a need to repeat it.
I see, makes sense.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]
prev parent reply other threads:[~2021-03-22 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 11:27 [PATCH net-next] net: dsa: hellcreek: Report switch name and ID Kurt Kanzenbach
2021-03-20 14:22 ` Andrew Lunn
2021-03-22 18:41 ` Kurt Kanzenbach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735wnf2uk.fsf@kmk-computers.de \
--to=kurt@kmk-computers$(echo .)de \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox