Subject: Re: [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err'

From: Kalle Valo <[email-masked]>
Date: Wed, 09 Oct 2019 15:58:01 +0300

zhengbin <[email-masked]> writes:

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: variable err set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <[email-masked]>
> Signed-off-by: zhengbin <[email-masked]>
> Acked-by: Ping-Ke Shih <[email-masked]>

There's no changelog, why did you resend? Document clearly the changes
so that maintainers don't need to guess what has changed:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing

-- 
Kalle Valo