From: Kalle Valo <kvalo@codeaurora•org>
To: Masahiro Yamada <yamada.masahiro@socionext•com>
Cc: linux-wireless@vger•kernel.org,
brcm80211-dev-list.pdl@broadcom•com,
Franky Lin <franky.lin@broadcom•com>,
Intel Linux Wireless <linuxwifi@intel•com>,
Luca Coelho <luciano.coelho@intel•com>,
Johannes Berg <johannes.berg@intel•com>,
netdev@vger•kernel.org,
Emmanuel Grumbach <emmanuel.grumbach@intel•com>,
Chi-Hsien Lin <chi-hsien.lin@cypress•com>,
Hin-Tak Leung <htl10@users•sourceforge.net>,
Larry Finger <Larry.Finger@lwfinger•net>,
Herton Ronaldo Krzesinski <herton@canonical•com>,
Hante Meuleman <hante.meuleman@broadcom•com>,
Wright Feng <wright.feng@cypress•com>,
Arend van Spriel <arend.vanspriel@broadcom•com>,
brcm80211-dev-list@cypress•com, linux-kernel@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] net: wireless: prefix header search paths with $(srctree)/
Date: Mon, 28 Jan 2019 10:21:31 +0200 [thread overview]
Message-ID: <8736pd2nw4.fsf@codeaurora.org> (raw)
In-Reply-To: <1548429480-22137-1-git-send-email-yamada.masahiro@socionext.com> (Masahiro Yamada's message of "Sat, 26 Jan 2019 00:18:00 +0900")
Masahiro Yamada <yamada.masahiro@socionext•com> writes:
> Currently, the Kbuild core manipulates header search paths in a crazy
> way [1].
>
> To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
> the search paths in the srctree. Some Makefiles are already written in
> that way, but not all. The goal of this work is to make the notation
> consistent, and finally get rid of the gross hacks.
>
> Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
> ("kbuild: do not drop -I without parameter").
>
> I also removed one header search path in:
>
> drivers/net/wireless/broadcom/brcm80211/brcmutil/Makefile
>
> I was able to compile without it.
>
> [1]: https://patchwork.kernel.org/patch/9632347/
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext•com>
> ---
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/Makefile | 4 ++--
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/Makefile | 6 +++---
> drivers/net/wireless/broadcom/brcm80211/brcmutil/Makefile | 4 +---
> drivers/net/wireless/intel/iwlwifi/dvm/Makefile | 2 +-
> drivers/net/wireless/intel/iwlwifi/mvm/Makefile | 2 +-
> drivers/net/wireless/realtek/rtl818x/rtl8180/Makefile | 2 +-
> drivers/net/wireless/realtek/rtl818x/rtl8187/Makefile | 2 +-
> 7 files changed, 10 insertions(+), 12 deletions(-)
Luca, is it ok if I take this to wireless-drivers-next even though it
touches iwlwifi makefiles?
--
Kalle Valo
next prev parent reply other threads:[~2019-01-28 8:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 15:18 [PATCH] net: wireless: prefix header search paths with $(srctree)/ Masahiro Yamada
2019-01-28 8:21 ` Kalle Valo [this message]
2019-01-28 8:26 ` Luca Coelho
2019-02-01 12:43 ` [PATCH] " Kalle Valo
[not found] <883460220.650537.1548861942189.ref@mail.yahoo.com>
2019-01-30 15:25 ` [PATCH] net: " Hin-Tak Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736pd2nw4.fsf@codeaurora.org \
--to=kvalo@codeaurora$(echo .)org \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=arend.vanspriel@broadcom$(echo .)com \
--cc=brcm80211-dev-list.pdl@broadcom$(echo .)com \
--cc=brcm80211-dev-list@cypress$(echo .)com \
--cc=chi-hsien.lin@cypress$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=emmanuel.grumbach@intel$(echo .)com \
--cc=franky.lin@broadcom$(echo .)com \
--cc=hante.meuleman@broadcom$(echo .)com \
--cc=herton@canonical$(echo .)com \
--cc=htl10@users$(echo .)sourceforge.net \
--cc=johannes.berg@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linuxwifi@intel$(echo .)com \
--cc=luciano.coelho@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wright.feng@cypress$(echo .)com \
--cc=yamada.masahiro@socionext$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox