From: Mikhail Skorzhinskii <mskorzhinskiy@solarflare•com>
To: Sagi Grimberg <sagi@grimberg•me>
Cc: <linux-nvme@lists•infradead.org>, <linux-block@vger•kernel.org>,
<netdev@vger•kernel.org>, "David S. Miller" <davem@davemloft•net>,
"Keith Busch" <keith.busch@intel•com>,
Christoph Hellwig <hch@lst•de>
Subject: Re: [PATCH v2 14/14] nvme-tcp: add NVMe over TCP host driver
Date: Wed, 21 Nov 2018 15:01:11 +0300 [thread overview]
Message-ID: <8736rufxmg.fsf@solarflare.com> (raw)
In-Reply-To: <20181120030019.31738-16-sagi@grimberg.me>
Sagi Grimberg <sagi@grimberg•me> writes:
> +static inline void nvme_tcp_queue_request(struct nvme_tcp_request *req)
> +{
> + struct nvme_tcp_queue *queue = req->queue;
> +
> + spin_lock_bh(&queue->lock);
> + list_add_tail(&req->entry, &queue->send_list);
> + spin_unlock_bh(&queue->lock);
> +
> + queue_work_on(queue->io_cpu, nvme_tcp_wq, &queue->io_work);
> +}
May be I missing something, but why bother with bottom half version of
locking?
There are few places where this lock could be accessed:
(1) From ->queue_rq() call;
(2) From submitting new AEN request;
(3) From receiving new R2T;
Which one if these originates from bottom half? Not 100% about queue_rq
data path, but (2) and (3) looks perfectly safe for me.
Possibly just a relic of some previous iterations of experimenting?
Mikhail Skorzhinskii
next prev parent reply other threads:[~2018-11-22 0:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 3:00 [PATCH v2 00/14] TCP transport binding for NVMe over Fabrics Sagi Grimberg
2018-11-20 3:00 ` [PATCH v2 01/14] ath6kl: add ath6kl_ prefix to crypto_type Sagi Grimberg
2018-11-20 3:00 ` [PATCH v2 02/14] datagram: open-code copy_page_to_iter Sagi Grimberg
2018-11-20 3:00 ` [PATCH v2 03/14] iov_iter: pass void csum pointer to csum_and_copy_to_iter Sagi Grimberg
2018-11-20 3:00 ` [PATCH v2 04/14] datagram: consolidate datagram copy to iter helpers Sagi Grimberg
2018-11-20 3:00 ` [PATCH v2 04/14] net/datagram: " Sagi Grimberg
2018-11-20 3:00 ` [PATCH v2 05/14] iov_iter: introduce hash_and_copy_to_iter helper Sagi Grimberg
2018-11-20 3:00 ` [PATCH v2 06/14] datagram: introduce skb_copy_and_hash_datagram_iter helper Sagi Grimberg
2018-11-20 3:00 ` [PATCH v2 07/14] nvme-core: add work elements to struct nvme_ctrl Sagi Grimberg
2018-11-21 13:04 ` Christoph Hellwig
2018-11-21 22:28 ` Sagi Grimberg
2018-11-20 3:00 ` [PATCH v2 08/14] nvmet: Add install_queue callout Sagi Grimberg
2018-11-21 13:05 ` Christoph Hellwig
2018-11-20 3:00 ` [PATCH v2 09/14] nvmet: allow configfs tcp trtype configuration Sagi Grimberg
2018-11-21 13:05 ` Christoph Hellwig
2018-11-20 3:00 ` [PATCH v2 10/14] nvme-fabrics: allow user passing header digest Sagi Grimberg
2018-11-21 13:06 ` Christoph Hellwig
2018-11-20 3:00 ` [PATCH v2 11/14] nvme-fabrics: allow user passing data digest Sagi Grimberg
2018-11-21 13:06 ` Christoph Hellwig
2018-11-20 3:00 ` [PATCH v2 12/14] nvme-tcp: Add protocol header Sagi Grimberg
2018-11-20 3:00 ` [PATCH v2 13/14] nvmet-tcp: add NVMe over TCP target driver Sagi Grimberg
2018-11-21 13:07 ` Christoph Hellwig
2018-11-21 22:29 ` Sagi Grimberg
2018-11-20 3:00 ` [PATCH v2 14/14] nvme-tcp: add NVMe over TCP host driver Sagi Grimberg
2018-11-20 23:34 ` Narayan Ayalasomayajula
2018-11-21 0:10 ` Sagi Grimberg
2018-11-21 0:41 ` Ethan Weidman
2018-11-21 5:43 ` Sagi Grimberg
2018-11-21 8:56 ` Christoph Hellwig
2018-11-21 22:27 ` Sagi Grimberg
2018-11-21 12:01 ` Mikhail Skorzhinskii [this message]
2018-11-21 22:28 ` Sagi Grimberg
2018-11-20 3:00 ` [PATCH nvme-cli v2 15/14] nvme: Add TCP transport Sagi Grimberg
2018-11-20 9:36 ` Arend van Spriel
2018-11-20 22:56 ` Sagi Grimberg
2018-11-20 3:00 ` [PATCH nvme-cli v2 16/14] fabrics: add tcp port tsas decoding Sagi Grimberg
2018-11-20 3:00 ` [PATCH nvme-cli v2 17/14] fabrics: add transport header and data digest Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736rufxmg.fsf@solarflare.com \
--to=mskorzhinskiy@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hch@lst$(echo .)de \
--cc=keith.busch@intel$(echo .)com \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-nvme@lists$(echo .)infradead.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sagi@grimberg$(echo .)me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox