Subject: Re: [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k

From: Gregory CLEMENT <[email-masked]>
Date: Thu, 08 Jun 2017 10:55:01 +0200

Hi Antoine,
 
 On jeu., juin 08 2017, Antoine Tenart <[email-masked]> wrote:

> Hi Gregory,
>
> On Wed, Jun 07, 2017 at 10:38:10AM +0200, Antoine Tenart wrote:
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> index 2a99ff8fca2a..594356243ddb 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> @@ -103,6 +103,13 @@
>>  				clocks = <&cps_syscon0 1 9>, <&cps_syscon0 1 5>;
>>  			};
>>  
>> +			cps_xmdio: mdio@12a600 {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +				compatible = "marvell,xmdio";
>> +				reg = <0x12a600 0x10>;
>> +			};
>> +
>
> Russell pointed out on IRC the mdio/xmdio interfaces aren't wired to
> anything on the mcbin. We could either disable these interfaces by
> default, or add explicit disables in the mcbin device tree.
>
> What's your thoughts on this?

I prefer that we disable it by default and only enable it on the boards
using it.

Thanks,

Gregory

>
> Thanks!
> Antoine
>
> -- 
> Antoine Ténart, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com