From: Nick Alcock <nix@esperi•org.uk>
To: Francois Romieu <romieu@fr•zoreil.com>
Cc: netdev@vger•kernel.org, David Miller <davem@davemloft•net>,
Andrej Ota <andrej@ota•si>
Subject: Re: [PATCH net 1/1] via-rhine: fix VLAN receive handling regression.
Date: Thu, 15 Oct 2015 08:24:51 +0100 [thread overview]
Message-ID: <8737xck30c.fsf@esperi.org.uk> (raw)
In-Reply-To: <20151014221437.GA8065@electric-eye.fr.zoreil.com> (Francois Romieu's message of "Thu, 15 Oct 2015 00:14:37 +0200")
On 14 Oct 2015, Francois Romieu told this:
> From: Andrej Ota <andrej@ota•si>
>
> Because eth_type_trans() consumes ethernet header worth of bytes, a call
> to read TCI from end of packet using rhine_rx_vlan_tag() no longer works
> as it's reading from an invalid offset.
>
> Tested to be working on PCEngines Alix board.
LGTM, though not tested because I don't have any vlans set up on my VIA
Rhine box and I can't reboot it at the moment. :)
next prev parent reply other threads:[~2015-10-15 8:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 22:14 [PATCH net 1/1] via-rhine: fix VLAN receive handling regression Francois Romieu
2015-10-15 7:24 ` Nick Alcock [this message]
2015-10-16 8:02 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2013-08-07 0:34 [PATCH net] ipv6: don't stop backtracking in fib6_lookup_1 if subtree does not match Hannes Frederic Sowa
2013-08-07 19:58 ` Teco Boot
2015-12-02 9:55 ` [PATCH net 1/1] via-rhine: fix VLAN receive handling regression Teco Boot
2015-12-03 20:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737xck30c.fsf@esperi.org.uk \
--to=nix@esperi$(echo .)org.uk \
--cc=andrej@ota$(echo .)si \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=romieu@fr$(echo .)zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox