Subject: Re: [RFC PATCH 2/2] netpoll: Don't poll for received packets

From: [email-masked] (Eric W. Biederman)
Date: Thu, 13 Mar 2014 13:48:29 -0700

Cong Wang <[email-masked]> writes:

> On Tue, Mar 11, 2014 at 1:45 AM, Eric W. Biederman
> <[email-masked]> wrote:
>> -       work = napi->poll(napi, budget);
>> -       trace_napi_poll(napi);
>> +       /* Use a budget of 0 to request the drivers not process
>> +        * their receive queue.  Warn when they do anyway.
>> +        */
>> +       work = napi->poll(napi, 0);
>> +       WARN_ON_ONCE(work != 0);
>>
>
> Adding more printk's in netpoll call path would only bring more
> troubles.

That is why I used WARN_ON_ONCE.  So we are alerted to problems but
because it only prints once service won't be denied if nothing except
that warning cares.

Eric