From: "Bjørn Mork" <bjorn@mork•no>
To: Ming Lei <ming.lei@canonical•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Jiri Kosina <jkosina@suse•cz>,
Alan Stern <stern@rowland•harvard.edu>,
Oliver Neukum <oneukum@suse•de>,
netdev@vger•kernel.org, linux-usb@vger•kernel.org,
linux-input@vger•kernel.org
Subject: Re: [PATCH v1 7/7] usbnet: qmi_wwan: don't recover device if suspend fails in system sleep
Date: Wed, 06 Mar 2013 13:07:03 +0100 [thread overview]
Message-ID: <8738w8ohp4.fsf@nemi.mork.no> (raw)
In-Reply-To: <1362565557-15884-8-git-send-email-ming.lei@canonical.com> (Ming Lei's message of "Wed, 6 Mar 2013 18:25:56 +0800")
Ming Lei <ming.lei@canonical•com> writes:
> If suspend callback fails in system sleep context, usb core will
> ignore the failure and let system sleep go ahead further, so
> this patch doesn't recover device under this situation.
>
> Cc: Bjørn Mork <bjorn@mork•no>
> Signed-off-by: Ming Lei <ming.lei@canonical•com>
> ---
> drivers/net/usb/qmi_wwan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index efb5c7c..1b4367c 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -294,7 +294,7 @@ static int qmi_wwan_suspend(struct usb_interface *intf, pm_message_t message)
>
> if (intf == info->control && info->subdriver && info->subdriver->suspend)
> ret = info->subdriver->suspend(intf, message);
> - if (ret < 0)
> + if (ret < 0 && PMSG_IS_AUTO(message))
> usbnet_resume(intf);
> err:
> return ret;
Same comment as for cdc_mbim: This is more confusing than helpful
because it makes it look like qmi_wwan_suspend can return an error on
system suspend. Better adding a comment explaining why the original
code is OK.
Bjørn
prev parent reply other threads:[~2013-03-06 12:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 10:25 [PATCH v1 0/7] USB: don't recover device if suspend fails in system sleep Ming Lei
2013-03-06 10:25 ` [PATCH v1 2/7] USB: serial: handle suspend failure path correctly Ming Lei
2013-03-06 10:25 ` [PATCH v1 3/7] USBHID: don't recover device if suspend fails in system sleep Ming Lei
2013-03-06 10:25 ` [PATCH v1 4/7] usbnet: cdc_mbim: " Ming Lei
2013-03-06 12:04 ` Bjørn Mork
[not found] ` <877glkohu2.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2013-03-06 13:48 ` Ming Lei
2013-03-06 14:53 ` Bjørn Mork
2013-03-06 10:25 ` [PATCH v1 5/7] usbnet: smsc95xx: " Ming Lei
2013-03-06 10:25 ` [PATCH v1 6/7] usbnet: smsc75xx: " Ming Lei
[not found] ` <1362565557-15884-1-git-send-email-ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2013-03-06 10:25 ` [PATCH v1 1/7] USB: adds comment on suspend callback Ming Lei
2013-03-06 15:25 ` Alan Stern
2013-03-07 2:09 ` Ming Lei
2013-03-06 10:25 ` [PATCH v1 7/7] usbnet: qmi_wwan: don't recover device if suspend fails in system sleep Ming Lei
2013-03-06 12:07 ` Bjørn Mork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738w8ohp4.fsf@nemi.mork.no \
--to=bjorn@mork$(echo .)no \
--cc=davem@davemloft$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jkosina@suse$(echo .)cz \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=ming.lei@canonical$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oneukum@suse$(echo .)de \
--cc=stern@rowland$(echo .)harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox