Subject: Re: [PATCH] pkt_sched: Control group classifier

From: Andi Kleen <[email-masked]>
Date: Thu, 16 Oct 2008 07:41:55 +0200

Thomas Graf <[email-masked]> writes:
>
> The principle of the classifier is to directly access the
> task_struct via get_current(). In order for this to work,
> classification requests from softirqs must be ignored.

You mean the classifier just wants to know if it runs
as a softirq?

> This is
> not a problem because the vast majority of packets in softirq
> context are not assigned to a task anyway. For this to work, a
> mechanism is needed to trace softirq context.
> The only existing
> way to do so is to use the TRACE_IRQFLAGS feature, unfortunately

Does't softirq_count() > 0 check that?

-Andi

-- 
[email-masked]