Subject: Re: [PATCH v3 18/24] wfx: add data_tx.c/data_tx.h

From: Kalle Valo <[email-masked]>
Date: Tue, 22 Dec 2020 17:31:22 +0200

Jerome Pouiller <[email-masked]> writes:

> +void wfx_tx(struct ieee80211_hw *hw, struct ieee80211_tx_control *control,
> +	    struct sk_buff *skb)
> +{
> +	struct wfx_dev *wdev = hw->priv;
> +	struct wfx_vif *wvif;
> +	struct ieee80211_sta *sta = control ? control->sta : NULL;
> +	struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
> +	struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data;
> +	size_t driver_data_room = sizeof_field(struct ieee80211_tx_info,
> +					       rate_driver_data);
> +
> +	compiletime_assert(sizeof(struct wfx_tx_priv) <= driver_data_room,
> +			   "struct tx_priv is too large");

Interesting, never seen compiletime_assert() before. But I suspect
BUILD_BUG_ON_MSG() is preferred, at least there are more users.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches