From: Rainer Weikusat <rweikusat@mobileactivedefense•com>
To: <olivier@mauras•ch>
Cc: Rainer Weikusat <rweikusat@mobileactivedefense•com>,
Jason Baron <jbaron@akamai•com>, <davem@davemloft•net>,
<netdev@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
<minipli@googlemail•com>, <normalperson@yhbt•net>,
<eric.dumazet@gmail•com>, <viro@zeniv•linux.org.uk>,
<davidel@xmailserver•org>, <dave@stgolabs•net>,
<pageexec@freemail•hu>, <torvalds@linux-foundation•org>,
<peterz@infradead•org>
Subject: Re: [RFC] unix: fix use-after-free in unix_dgram_poll()/ 4.2.5
Date: Mon, 02 Nov 2015 21:55:42 +0000 [thread overview]
Message-ID: <874mh4gj6p.fsf@doppelsaurus.mobileactivedefense.com> (raw)
In-Reply-To: <57d2f5b6aae251957bff7a1a52b8bf2c@core-hosting.net> (Olivier Mauras's message of "Mon, 02 Nov 2015 11:01:08 +0200")
Olivier Mauras <olivier@mauras•ch> writes:
[...]
> I've encountered issues with Jason's patch ported to 3.14.x which would break
> openldap, rendering it unable to answer any query - Here's a strace of the
> slapd process in this state http://pastebin.ca/3226383
> Just ported Rainer's patch to 3.14 and so far I can't reproduce the issue -
I may be missing something here but the final state according to the
trace it that thread 775 of the process blocks in epoll_wait with a
descriptor set containing only a listening TCP socket (8) and waiting
for new connections. I don't think this can execute any code
changed by my patch and I'm fairly certain for this for Jason's, too:
Both are about AF_UNIX datagram sockets and the specific case where
either a write couldn't complete because the backlog of the receive
queue of the 1 side of a n:1 datagram socket arrangement was considered
too large or where a 'poll for write' check returned 'not writeable' for
the same reason.
Judging from the 2.4.42 sources, OpenLDAP doesn't use AF_UNIX datagram
sockets at all so it shouldn't ever be affected by any changes to the
code handling them.
next prev parent reply other threads:[~2015-11-02 21:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 20:43 [PATCH v2 0/3] af_unix: fix use-after-free Jason Baron
2015-10-02 20:43 ` [PATCH v2 1/3] unix: fix use-after-free in unix_dgram_poll() Jason Baron
2015-10-03 5:46 ` Mathias Krause
2015-10-03 17:02 ` Rainer Weikusat
2015-10-04 17:41 ` Rainer Weikusat
2015-10-05 16:31 ` Rainer Weikusat
2015-10-05 16:54 ` Eric Dumazet
2015-10-05 17:20 ` Rainer Weikusat
2015-10-05 17:55 ` Jason Baron
2015-10-12 20:41 ` Rainer Weikusat
2015-10-14 3:44 ` Jason Baron
2015-10-14 17:47 ` Rainer Weikusat
2015-10-15 2:54 ` Jason Baron
2015-10-18 20:58 ` Rainer Weikusat
2015-10-19 15:07 ` Jason Baron
2015-10-20 22:29 ` Rainer Weikusat
2015-10-21 17:34 ` Rainer Weikusat
2015-10-28 16:46 ` [RFC] " Rainer Weikusat
2015-10-28 17:57 ` Jason Baron
2015-10-29 14:23 ` Rainer Weikusat
2015-10-30 20:52 ` [RFC] unix: fix use-after-free in unix_dgram_poll()/ 4.2.5 Rainer Weikusat
[not found] ` <57d2f5b6aae251957bff7a1a52b8bf2c@core-hosting.net>
2015-11-02 21:55 ` Rainer Weikusat [this message]
2015-10-02 20:43 ` [PATCH v2 2/3] af_unix: Convert gc_flags to flags Jason Baron
2015-10-02 20:44 ` [PATCH v2 3/3] af_unix: optimize the unix_dgram_recvmsg() Jason Baron
2015-10-05 7:41 ` Peter Zijlstra
2015-10-05 17:13 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mh4gj6p.fsf@doppelsaurus.mobileactivedefense.com \
--to=rweikusat@mobileactivedefense$(echo .)com \
--cc=dave@stgolabs$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=davidel@xmailserver$(echo .)org \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=jbaron@akamai$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=minipli@googlemail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=normalperson@yhbt$(echo .)net \
--cc=olivier@mauras$(echo .)ch \
--cc=pageexec@freemail$(echo .)hu \
--cc=peterz@infradead$(echo .)org \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox