Subject: Re: [Patch net-next v2] pktgen: support net namespace

From: [email-masked] (Eric W. Biederman)
Date: Mon, 28 Jan 2013 18:36:02 -0800

Cong Wang <[email-masked]> writes:

> From: Cong Wang <[email-masked]>
>
> v2: remove a useless check
>
> This patch add net namespace to pktgen, so that
> we can use pktgen in different namespaces.
>
> Cc: Eric W. Biederman <[email-masked]>
> Cc: David S. Miller <[email-masked]>
> Signed-off-by: Cong Wang <[email-masked]>
>
> ---
>  net/core/pktgen.c |  123 +++++++++++++++++++++++++++++++++++------------------
>  1 files changed, 81 insertions(+), 42 deletions(-)

Skiming through this again I have spotted what looks like a pretty
major bug.  You are limiting yourself to one network device per network
namespace when the actual limit is one network device per thread.

I think you can just kill the dev member of pktgen_net and the two or
three lines of code that touch it.

> +static int pg_net_id __read_mostly;
> +
> +struct pktgen_net {
> +	struct net		*net;
> +	struct net_device	*dev;
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +	struct proc_dir_entry	*proc_dir;
>  };

Eric