Subject: Re: [Patch net-next] sctp: fix a compile error in sctp.h

From: [email-masked] (Eric W. Biederman)
Date: Wed, 15 Aug 2012 12:53:23 -0700

David Miller <[email-masked]> writes:

> From: Cong Wang <[email-masked]>
> Date: Wed, 15 Aug 2012 18:18:11 +0800
>
>> I got the following compile error:
>> 
>> In file included from include/net/sctp/checksum.h:46:0,
>>                  from net/ipv4/netfilter/nf_nat_proto_sctp.c:14:
>> include/net/sctp/sctp.h: In function ‘sctp_dbg_objcnt_init’:
>> include/net/sctp/sctp.h:370:88: error: parameter name omitted
>> include/net/sctp/sctp.h: In function ‘sctp_dbg_objcnt_exit’:
>> include/net/sctp/sctp.h:371:88: error: parameter name omitted
>> 
>> which is caused by
>> 
>> 	commit 13d782f6b4fbbaf9d0380a9947deb45a9de46ae7
>> 	Author: Eric W. Biederman <[email-masked]>
>> 	Date:   Mon Aug 6 08:45:15 2012 +0000
>> 
>> 	    sctp: Make the proc files per network namespace.
>> 
>> This patch could fix it.
>> 
>> Cc: David S. Miller <[email-masked]>
>> Cc: "Eric W. Biederman" <[email-masked]>
>> Signed-off-by: Cong Wang <[email-masked]>
>
> Applied thanks.
>
> I appended the SCTP debug objcnt procfs netns conversions by hand
> since Eric didn't handle it in his commit.
>
> Eric, please turn all relevant options both on and off when testing
> the build of your patches.  Thanks.

Grr. My apologies.  It looks like that one slipped by me this time :(

Eric