From: Peter Korsgaard <jacmet@sunsite•dk>
To: Wu Fengguang <wfg@linux•intel.com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] dm9601: warn on invalid mac address
Date: Wed, 07 Jan 2009 09:24:43 +0100 [thread overview]
Message-ID: <874p0bmsl0.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090107045258.GA8071@localhost> (Wu Fengguang's message of "Wed\, 7 Jan 2009 12\:52\:58 +0800")
>>>>> "Wu" == Wu Fengguang <wfg@linux•intel.com> writes:
Hi,
>> Also, it seems like you're not writing the random address to the
>> hardware registers, so you won't be able to receive any unicast -
>> You'll need to add a call to dm9601_set_mac_address() or similar.
Wu> Good catch. I had wanted to ask why it only works with promisc
Wu> mode ;-)
;)
Wu> Here is the tested patch.
Wu> Thanks,
Wu> Fengguang
Wu> ---
Wu> dm9601: tell HW about random generated mac address
Wu> Otherwise unicast RX will only work in promisc mode.
Wu> Signed-off-by: Peter Korsgaard <jacmet@sunsite•dk>
Wu> Signed-off-by: Wu Fengguang <fengguang.wu@intel•com>
Acked-by: Peter Korsgaard <jacmet@sunsite•dk>
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-01-07 8:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 9:10 [PATCH] dm9601: warn on invalid mac address Wu Fengguang
2009-01-06 9:18 ` Peter Korsgaard
2009-01-06 9:47 ` Wu Fengguang
2009-01-06 11:17 ` Peter Korsgaard
2009-01-07 4:52 ` Wu Fengguang
2009-01-07 8:24 ` Peter Korsgaard [this message]
2009-01-08 18:45 ` David Miller
2009-01-06 11:52 ` Ben Hutchings
2009-01-06 18:52 ` David Miller
2009-01-07 4:55 ` Wu Fengguang
2009-01-07 8:25 ` Peter Korsgaard
2009-01-08 18:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874p0bmsl0.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wfg@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox