From: Petr Machata <petrm@nvidia•com>
To: Ratheesh Kannoth <rkannoth@marvell•com>
Cc: <linux-kernel@vger•kernel.org>, <linux-rdma@vger•kernel.org>,
<netdev@vger•kernel.org>, <oss-drivers@corigine•com>,
<akiyano@amazon•com>, <andrew+netdev@lunn•ch>,
<anthony.l.nguyen@intel•com>, <arkadiusz.kubalewski@intel•com>,
<brett.creeley@amd•com>, <darinzon@amazon•com>,
<davem@davemloft•net>, <donald.hunter@gmail•com>,
<edumazet@google•com>, <horms@kernel•org>, <idosch@nvidia•com>,
<ivecera@redhat•com>, <jiri@resnulli•us>, <kuba@kernel•org>,
<leon@kernel•org>, <mbloch@nvidia•com>,
<michael.chan@broadcom•com>, <pabeni@redhat•com>,
<pavan.chebbi@broadcom•com>, <petrm@nvidia•com>,
<Prathosh.Satish@microchip•com>, <przemyslaw.kitszel@intel•com>,
<saeedm@nvidia•com>, <sgoutham@marvell•com>, <tariqt@nvidia•com>,
<vadim.fedorenko@linux•dev>
Subject: Re: [PATCH v13 net-next 3/9] devlink: pass param values by pointer
Date: Mon, 11 May 2026 10:52:09 +0200 [thread overview]
Message-ID: <875x4upbtn.fsf@nvidia.com> (raw)
In-Reply-To: <20260511033923.1301976-4-rkannoth@marvell.com>
Ratheesh Kannoth <rkannoth@marvell•com> writes:
> union devlink_param_value grows substantially once U64 array
> parameters are added to devlink (from 32 bytes to over 264 bytes).
> devlink_nl_param_value_fill_one() and devlink_nl_param_value_put()
> copy the union by value in several places. Passing two instances as
> value arguments alone consumes over 528 bytes of stack; combined with
> deeper call chains the parameter stack can approach 800 bytes and trip
> CONFIG_FRAME_WARN more easily.
>
> Switch internal helpers and exported driver APIs to pass pointers to
> union devlink_param_value rather than passing the union by value.
>
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell•com>
Reviewed-by: Petr Machata <petrm@nvidia•com> # for mlxsw
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
> index d76246301f67..308d8a94865f 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/core.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
> @@ -1306,11 +1306,11 @@ static int mlxsw_core_fw_flash_update(struct mlxsw_core *mlxsw_core,
> }
>
> static int mlxsw_core_devlink_param_fw_load_policy_validate(struct devlink *devlink, u32 id,
> - union devlink_param_value val,
> + union devlink_param_value *val,
> struct netlink_ext_ack *extack)
> {
> - if (val.vu8 != DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_DRIVER &&
> - val.vu8 != DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_FLASH) {
> + if (val->vu8 != DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_DRIVER &&
> + val->vu8 != DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_FLASH) {
> NL_SET_ERR_MSG_MOD(extack, "'fw_load_policy' must be 'driver' or 'flash'");
> return -EINVAL;
> }
> @@ -1337,7 +1337,7 @@ static int mlxsw_core_fw_params_register(struct mlxsw_core *mlxsw_core)
> value.vu8 = DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_DRIVER;
> devl_param_driverinit_value_set(devlink,
> DEVLINK_PARAM_GENERIC_ID_FW_LOAD_POLICY,
> - value);
> + &value);
> return 0;
> }
>
next prev parent reply other threads:[~2026-05-11 8:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 3:39 [PATCH v13 net-next 0/9] octeontx2-af: npc: Enhancements Ratheesh Kannoth
2026-05-11 3:39 ` [PATCH v13 net-next 1/9] octeontx2-af: npc: cn20k: debugfs enhancements Ratheesh Kannoth
2026-05-11 3:39 ` [PATCH v13 net-next 2/9] net/mlx5e: Reduce stack use reading PCIe congestion thresholds Ratheesh Kannoth
2026-05-11 9:02 ` Dragos Tatulea
2026-05-11 3:39 ` [PATCH v13 net-next 3/9] devlink: pass param values by pointer Ratheesh Kannoth
2026-05-11 8:52 ` Petr Machata [this message]
2026-05-12 1:43 ` Kiyanovski, Arthur
2026-05-11 3:39 ` [PATCH v13 net-next 4/9] devlink: Implement devlink param multi attribute nested data values Ratheesh Kannoth
2026-05-12 15:54 ` Ratheesh Kannoth
2026-05-14 3:58 ` Ratheesh Kannoth
2026-05-11 3:39 ` [PATCH v13 net-next 5/9] octeontx2-af: npc: cn20k: add subbank search order control Ratheesh Kannoth
2026-05-14 4:01 ` Ratheesh Kannoth
2026-05-11 3:39 ` [PATCH v13 net-next 6/9] octeontx2: cn20k: Coordinate default rules with NIX LF lifecycle Ratheesh Kannoth
2026-05-14 4:12 ` Ratheesh Kannoth
2026-05-11 3:39 ` [PATCH v13 net-next 7/9] octeontx2-af: npc: Support for custom KPU profile from filesystem Ratheesh Kannoth
2026-05-14 4:13 ` Ratheesh Kannoth
2026-05-11 3:39 ` [PATCH v13 net-next 8/9] octeontx2: cn20k: Respect NPC MCAM X2/X4 profile in flows and DFT alloc Ratheesh Kannoth
2026-05-14 4:14 ` Ratheesh Kannoth
2026-05-11 3:39 ` [PATCH v13 net-next 9/9] octeontx2-af: npc: cn20k: Allocate npc_priv and dstats dynamically Ratheesh Kannoth
2026-05-14 4:15 ` Ratheesh Kannoth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x4upbtn.fsf@nvidia.com \
--to=petrm@nvidia$(echo .)com \
--cc=Prathosh.Satish@microchip$(echo .)com \
--cc=akiyano@amazon$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=arkadiusz.kubalewski@intel$(echo .)com \
--cc=brett.creeley@amd$(echo .)com \
--cc=darinzon@amazon$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=idosch@nvidia$(echo .)com \
--cc=ivecera@redhat$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=mbloch@nvidia$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@corigine$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=rkannoth@marvell$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox