From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Eric Dumazet <edumazet@google•com>,
"David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>
Cc: Willem de Bruijn <willemb@google•com>,
Soheil Hassas Yeganeh <soheil@google•com>,
Neal Cardwell <ncardwell@google•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
Cong Wang <xiyou.wangcong@gmail•com>,
Jiri Pirko <jiri@resnulli•us>,
netdev@vger•kernel.org, eric.dumazet@gmail•com,
Eric Dumazet <edumazet@google•com>
Subject: Re: [PATCH v2 net-next 0/4] net_sched: sch_fq: add WRR scheduling and 3 bands
Date: Mon, 02 Oct 2023 15:52:59 +0200 [thread overview]
Message-ID: <875y3pgmh0.fsf@toke.dk> (raw)
In-Reply-To: <20231002131738.1868703-1-edumazet@google.com>
Eric Dumazet <edumazet@google•com> writes:
> As discussed in Netconf 2023 in Paris last week, this series adds
> to FQ the possibility of replacing pfifo_fast for most setups.
>
> FQ provides fairness among flows, but malicious applications
> can cause problems by using thousands of sockets.
>
> Having 3 bands like pfifo_fast can make sure that applications
> using high prio packets (eg AF4) can get guaranteed throughput
> even if thousands of low priority flows are competing.
>
> Added complexity in FQ does not matter in many cases when/if
> fastpath added in the prior series is used.
>
> v2: augmented two extack messages (Toke)
Thanks!
For the series:
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat•com>
next prev parent reply other threads:[~2023-10-02 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 13:17 [PATCH v2 net-next 0/4] net_sched: sch_fq: add WRR scheduling and 3 bands Eric Dumazet
2023-10-02 13:17 ` [PATCH v2 net-next 1/4] net_sched: sch_fq: remove q->ktime_cache Eric Dumazet
2023-10-02 13:17 ` [PATCH v2 net-next 2/4] net_sched: export pfifo_fast prio2band[] Eric Dumazet
2023-10-02 13:17 ` [PATCH v2 net-next 3/4] net_sched: sch_fq: add 3 bands and WRR scheduling Eric Dumazet
2023-10-02 13:17 ` [PATCH v2 net-next 4/4] net_sched: sch_fq: add TCA_FQ_WEIGHTS attribute Eric Dumazet
2023-10-02 13:52 ` Toke Høiland-Jørgensen [this message]
2023-10-05 11:40 ` [PATCH v2 net-next 0/4] net_sched: sch_fq: add WRR scheduling and 3 bands patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y3pgmh0.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=ncardwell@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=soheil@google$(echo .)com \
--cc=willemb@google$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox