From: Rahul Rameshbabu <rrameshbabu@nvidia•com>
To: Vadim Fedorenko <vadfed@meta•com>
Cc: Gal Pressman <gal@nvidia•com>, Bar Shapira <bshapira@nvidia•com>,
Vadim Fedorenko <vadim.fedorenko@linux•dev>,
Saeed Mahameed <saeedm@nvidia•com>,
Jakub Kicinski <kuba@kernel•org>,
Richard Cochran <richardcochran@gmail•com>,
<netdev@vger•kernel.org>
Subject: Re: [PATCH net] Revert "net/mlx5: Update cyclecounter shift value to improve ptp free running mode precision"
Date: Tue, 15 Aug 2023 09:53:27 -0700 [thread overview]
Message-ID: <875y5gl01k.fsf@nvidia.com> (raw)
In-Reply-To: <20230815151507.3028503-1-vadfed@meta.com> (Vadim Fedorenko's message of "Tue, 15 Aug 2023 08:15:07 -0700")
On Tue, 15 Aug, 2023 08:15:07 -0700 Vadim Fedorenko <vadfed@meta•com> wrote:
> From: Vadim Fedorenko <vadim.fedorenko@linux•dev>
>
> This reverts commit 6a40109275626267ebf413ceda81c64719b5c431.
>
> There was an assumption in the original commit that all the devices
> supported by mlx5 advertise 1GHz as an internal timer frequency.
> Apparently at least ConnectX-4 Lx (MCX4431N-GCAN) provides 156.250Mhz
> as an internal frequency and the original commit breaks PTP
> synchronization on these cards.
>
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux•dev>
> ---
I agree with this revert. This change was made with the assumption that
all mlx5 compatible devices were running a 1Ghz internal timer. Will
sync with folks internally about how we can support higher precision
free running mode while accounting for the different device timer clock
speeds.
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia•com>
next prev parent reply other threads:[~2023-08-15 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 15:15 [PATCH net] Revert "net/mlx5: Update cyclecounter shift value to improve ptp free running mode precision" Vadim Fedorenko
2023-08-15 16:53 ` Rahul Rameshbabu [this message]
2023-08-16 21:57 ` Rahul Rameshbabu
2023-08-17 2:38 ` Jakub Kicinski
2023-08-17 16:37 ` Saeed Mahameed
2023-08-21 21:37 ` Vadim Fedorenko
2023-08-21 21:44 ` Rahul Rameshbabu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y5gl01k.fsf@nvidia.com \
--to=rrameshbabu@nvidia$(echo .)com \
--cc=bshapira@nvidia$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richardcochran@gmail$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=vadfed@meta$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox