From: Gregory CLEMENT <gregory.clement@free-electrons•com>
To: Rob Herring <robh@kernel•org>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>,
netdev@vger•kernel.org, devicetree@vger•kernel.org,
Frank Rowand <frowand.list@gmail•com>,
Marcin Wojtas <mw@semihalf•com>
Subject: Re: [PATCH 1/2] net: mvneta: remove bogus use of
Date: Thu, 20 Jul 2017 17:06:21 +0200 [thread overview]
Message-ID: <8760en5es2.fsf@free-electrons.com> (raw)
In-Reply-To: <20170720142711.12847-1-robh@kernel.org> (Rob Herring's message of "Thu, 20 Jul 2017 09:27:10 -0500")
Hi Rob,
On jeu., juil. 20 2017, Rob Herring <robh@kernel•org> wrote:
(Adding Marcin in CC who wrote this part of code)
> Nothing sets ever sets data, so it is always NULL. Remove it as this is
> the only user of data ptr in the whole kernel, and it is going to be
> removed from struct device_node.
Actually the use of device_node.data ptr is not bogus and it is set in
mvneta_bm_probe:
http://elixir.free-electrons.com/linux/latest/source/drivers/net/ethernet/marvell/mvneta_bm.c#L433
Your patch will break the BM support on this driver. So if you need to
remove this data ptr, then you have to offer an alternative for it.
Thanks,
Gregory
>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
> Signed-off-by: Rob Herring <robh@kernel•org>
> ---
> Probably there's a better fix here to actually enable the h/w buffer
> manager.
>
> I intend to take this thru the DT tree as patch 2 is dependent on this.
>
> Rob
>
> drivers/net/ethernet/marvell/mvneta.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index 0aab74c2a209..5624f4b49f9d 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -4296,8 +4296,8 @@ static int mvneta_probe(struct platform_device *pdev)
>
> /* Obtain access to BM resources if enabled and already initialized */
> bm_node = of_parse_phandle(dn, "buffer-manager", 0);
> - if (bm_node && bm_node->data) {
> - pp->bm_priv = bm_node->data;
> + if (bm_node) {
> + pp->bm_priv = NULL;
> err = mvneta_bm_port_init(pdev, pp);
> if (err < 0) {
> dev_info(&pdev->dev, "use SW buffer management\n");
> --
> 2.11.0
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-07-20 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 14:27 [PATCH 1/2] net: mvneta: remove bogus use of device_node.data ptr Rob Herring
2017-07-20 14:27 ` [PATCH 2/2] of: remove unused struct " Rob Herring
2017-07-20 15:06 ` Gregory CLEMENT [this message]
2017-07-20 16:01 ` [PATCH 1/2] net: mvneta: remove bogus use of Marcin Wojtas
2017-07-20 16:02 ` Rob Herring
[not found] ` <CAL_JsqKTwju4=J=X1kvk=77fE1VddPh2N-wCi3A0mCAu+Qg1mA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-04 15:26 ` Gregory CLEMENT
2017-08-04 15:49 ` Marcin Wojtas
[not found] ` <20170720142711.12847-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-07-20 17:02 ` [PATCH 1/2] net: mvneta: remove bogus use of device_node.data ptr Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760en5es2.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=frowand.list@gmail$(echo .)com \
--cc=mw@semihalf$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robh@kernel$(echo .)org \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox