Subject: Re: [PATCH net-next 15/21] net: dsa: mv88e6xxx: factorize VLAN Ethertype

From: Vivien Didelot <[email-masked]>
Date: Sat, 07 May 2016 16:51:29 -0400

Hi Andrew,

Andrew Lunn <[email-masked]> writes:

> On Fri, May 06, 2016 at 05:57:17PM -0400, Vivien Didelot wrote:
>> The 6131 switch models have a Core Tag Type register. Add a
>> MV88E6XXX_FLAG_CORE_TAG_TYPE flag and set the VLAN Ethertype to 0x8100
>> in the shared setup code if it is present.
>
> Do you have any idea what the core tag is?

Core Tag Type is the global register 0x19 present only on 6185 and
similar. It is used when egressing double tagged frames. This value is
also checked when ingressing frames on ports in UseCoreTag mode.

Note that we might remove this flag and setup condition, because 0x8100
is the reset value anyway.

        Vivien