Subject: Re: [PATCH net,v2 1/2] net/mlx5e: fix memory leak in mlx5e_fs_tt_redirect_any_create

From: Rahul Rameshbabu <[email-masked]>
Date: Thu, 29 Jun 2023 20:18:51 -0700

On Fri, 30 Jun, 2023 09:49:02 +0800 Zhengchao Shao <[email-masked]> wrote:
> The memory pointed to by the fs->any pointer is not freed in the error
> path of mlx5e_fs_tt_redirect_any_create, which can lead to a memory leak.
> Fix by freeing the memory in the error path, thereby making the error path
> identical to mlx5e_fs_tt_redirect_any_destroy().
>
> Fixes: 0f575c20bf06 ("net/mlx5e: Introduce Flow Steering ANY API")
> Signed-off-by: Zhengchao Shao <[email-masked]>
> Reviewed-by: Simon Horman <[email-masked]>
> ---
> v2: update the 'any' member reference in fs to NULL before free fs_any
> ---

Thank you for contributing.

Reviewed-by: Rahul Rameshbabu <[email-masked]>