Subject: Re: [PATCH 3/3] q_cake: detect overflow in get_size

From: Toke Høiland-Jørgensen <[email-masked]>
Date: Thu, 16 Apr 2020 10:49:48 +0200

Odin Ugedal <[email-masked]> writes:

> This detects overflow during parsing of value:
>
> eg. running:
>
> $ tc qdisc add dev lo root cake memlimit 11gb
>
> currently gives a memlimit of "3072Mb", while with this patch it errors
> with 'illegal value for "memlimit": "11gb"', since memlinit is an
> unsigned integer.
>
> Signed-off-by: Odin Ugedal <[email-masked]>

> ---
>  tc/tc_util.c | 5 +++++

This is not strictly a change to q_cake, so think you have to change the
subject prefix (e.g. to "tc_util: detect overflow in get_size"). You can
still say in the commit message that you found the issue while testing
the cake code, though.

With that change:

Acked-by: Toke Høiland-Jørgensen <[email-masked]>