Subject: Re: [PATCH net-next 1/3] net/sched: Introduce action ct

From: Toke Høiland-Jørgensen <[email-masked]>
Date: Tue, 11 Jun 2019 17:34:50 +0200

Paul Blakey <[email-masked]> writes:

> On 6/11/2019 4:59 PM, Toke Høiland-Jørgensen wrote:
>> Paul Blakey <[email-masked]> writes:
>>
>>> Allow sending a packet to conntrack and set conntrack zone, mark,
>>> labels and nat parameters.
>> How is this different from the newly merged ctinfo action?
>>
>> -Toke
>
> Hi,
>
> ctinfo does one of two very specific things,
>
> 1) copies DSCP values that have been placed in the firewall conntrack 
> mark back into the IPv4/v6 diffserv field
>
> 2) copies the firewall conntrack mark to the skb's mark field (like 
> act_connmark)
>
> Originally ctinfo action was named conndscp (then conntrack, which is 
> what our ct shorthand stands for).
>
> We also talked about merging both at some point, but they seem only 
> coincidentally related.

Well, I'm predicting it will create some confusion to have them so
closely named... Not sure what the best way to fix that is, though...?

-Toke