From: ebiederm@xmission•com (Eric W. Biederman)
To: Robert Shearman <rshearma@brocade•com>
Cc: <davem@davemloft•net>, <netdev@vger•kernel.org>
Subject: Re: [PATCH v2 1/3] mpls: Per-device MPLS state
Date: Wed, 22 Apr 2015 10:25:48 -0500 [thread overview]
Message-ID: <877ft4mbgj.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <1429697679-13767-2-git-send-email-rshearma@brocade.com> (Robert Shearman's message of "Wed, 22 Apr 2015 11:14:37 +0100")
Robert Shearman <rshearma@brocade•com> writes:
> Add per-device MPLS state to supported interfaces. Use the presence of
> this state in mpls_route_add to determine that this is a supported
> interface.
>
> Use the presence of mpls_dev to drop packets that arrived on an
> unsupported interface - previously they were allowed through.
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission•com>
>
> Cc: "Eric W. Biederman" <ebiederm@xmission•com>
> Signed-off-by: Robert Shearman <rshearma@brocade•com>
> ---
> include/linux/netdevice.h | 4 ++++
> net/mpls/af_mpls.c | 50 +++++++++++++++++++++++++++++++++++++++++++++--
> net/mpls/internal.h | 3 +++
> 3 files changed, 55 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index bcbde799ec69..dae106a3a998 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -60,6 +60,7 @@ struct phy_device;
> struct wireless_dev;
> /* 802.15.4 specific */
> struct wpan_dev;
> +struct mpls_dev;
>
> void netdev_set_default_ethtool_ops(struct net_device *dev,
> const struct ethtool_ops *ops);
> @@ -1627,6 +1628,9 @@ struct net_device {
> void *ax25_ptr;
> struct wireless_dev *ieee80211_ptr;
> struct wpan_dev *ieee802154_ptr;
> +#if IS_ENABLED(CONFIG_MPLS_ROUTING)
> + struct mpls_dev __rcu *mpls_ptr;
> +#endif
>
> /*
> * Cache lines mostly used on receive path (including eth_type_trans())
> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
> index db8a2ea6d4de..ad45017eed99 100644
> --- a/net/mpls/af_mpls.c
> +++ b/net/mpls/af_mpls.c
> @@ -53,6 +53,11 @@ static struct mpls_route *mpls_route_input_rcu(struct net *net, unsigned index)
> return rt;
> }
>
> +static inline struct mpls_dev *mpls_dev_get(const struct net_device *dev)
> +{
> + return rcu_dereference_rtnl(dev->mpls_ptr);
> +}
> +
> static bool mpls_output_possible(const struct net_device *dev)
> {
> return dev && (dev->flags & IFF_UP) && netif_carrier_ok(dev);
> @@ -136,6 +141,7 @@ static int mpls_forward(struct sk_buff *skb, struct net_device *dev,
> struct mpls_route *rt;
> struct mpls_entry_decoded dec;
> struct net_device *out_dev;
> + struct mpls_dev *mdev;
> unsigned int hh_len;
> unsigned int new_header_size;
> unsigned int mtu;
> @@ -143,6 +149,10 @@ static int mpls_forward(struct sk_buff *skb, struct net_device *dev,
>
> /* Careful this entire function runs inside of an rcu critical section */
>
> + mdev = mpls_dev_get(dev);
> + if (!mdev)
> + goto drop;
> +
> if (skb->pkt_type != PACKET_HOST)
> goto drop;
>
> @@ -352,9 +362,9 @@ static int mpls_route_add(struct mpls_route_config *cfg)
> if (!dev)
> goto errout;
>
> - /* For now just support ethernet devices */
> + /* Ensure this is a supported device */
> err = -EINVAL;
> - if ((dev->type != ARPHRD_ETHER) && (dev->type != ARPHRD_LOOPBACK))
> + if (!mpls_dev_get(dev))
> goto errout;
>
> err = -EINVAL;
> @@ -428,10 +438,27 @@ errout:
> return err;
> }
>
> +static struct mpls_dev *mpls_add_dev(struct net_device *dev)
> +{
> + struct mpls_dev *mdev;
> + int err = -ENOMEM;
> +
> + ASSERT_RTNL();
> +
> + mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
> + if (!mdev)
> + return ERR_PTR(err);
> +
> + rcu_assign_pointer(dev->mpls_ptr, mdev);
> +
> + return mdev;
> +}
> +
> static void mpls_ifdown(struct net_device *dev)
> {
> struct mpls_route __rcu **platform_label;
> struct net *net = dev_net(dev);
> + struct mpls_dev *mdev;
> unsigned index;
>
> platform_label = rtnl_dereference(net->mpls.platform_label);
> @@ -443,14 +470,33 @@ static void mpls_ifdown(struct net_device *dev)
> continue;
> rt->rt_dev = NULL;
> }
> +
> + mdev = mpls_dev_get(dev);
> + if (!mdev)
> + return;
> +
> + RCU_INIT_POINTER(dev->mpls_ptr, NULL);
> +
> + kfree(mdev);
> }
>
> static int mpls_dev_notify(struct notifier_block *this, unsigned long event,
> void *ptr)
> {
> struct net_device *dev = netdev_notifier_info_to_dev(ptr);
> + struct mpls_dev *mdev;
>
> switch(event) {
> + case NETDEV_REGISTER:
> + /* For now just support ethernet devices */
> + if ((dev->type == ARPHRD_ETHER) ||
> + (dev->type == ARPHRD_LOOPBACK)) {
> + mdev = mpls_add_dev(dev);
> + if (IS_ERR(mdev))
> + return notifier_from_errno(PTR_ERR(mdev));
> + }
> + break;
> +
> case NETDEV_UNREGISTER:
> mpls_ifdown(dev);
> break;
> diff --git a/net/mpls/internal.h b/net/mpls/internal.h
> index fb6de92052c4..8090cb3099b4 100644
> --- a/net/mpls/internal.h
> +++ b/net/mpls/internal.h
> @@ -22,6 +22,9 @@ struct mpls_entry_decoded {
> u8 bos;
> };
>
> +struct mpls_dev {
> +};
> +
> struct sk_buff;
>
> static inline struct mpls_shim_hdr *mpls_hdr(const struct sk_buff *skb)
next prev parent reply other threads:[~2015-04-22 15:30 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 21:32 [PATCH net-next 0/5] mpls: Behaviour-changing improvements Robert Shearman
2015-03-19 21:32 ` [PATCH net-next 1/5] mpls: Use definition for reserved label checks Robert Shearman
2015-03-20 0:41 ` Eric W. Biederman
2015-03-20 14:12 ` Robert Shearman
2015-03-19 21:32 ` [PATCH net-next 2/5] mpls: Remove incorrect PHP comment Robert Shearman
2015-03-19 21:32 ` [PATCH net-next 3/5] mpls: Differentiate implicit-null and unlabeled neighbours Robert Shearman
2015-03-19 21:32 ` [PATCH net-next 4/5] mpls: Per-device enabling of packet forwarding Robert Shearman
2015-03-19 21:32 ` [PATCH net-next 5/5] mpls: Allow payload type to be associated with label routes Robert Shearman
2015-03-20 15:42 ` [PATCH net-next v2 0/5] mpls: Behaviour-changing improvements Robert Shearman
2015-03-20 15:42 ` [PATCH net-next v2 1/5] mpls: Use definition for reserved label checks Robert Shearman
2015-03-22 19:09 ` Eric W. Biederman
2015-03-20 15:42 ` [PATCH net-next v2 2/5] mpls: Remove incorrect PHP comment Robert Shearman
2015-03-22 19:12 ` Eric W. Biederman
2015-03-23 11:32 ` Robert Shearman
2015-03-23 18:16 ` Eric W. Biederman
2015-03-24 15:18 ` Robert Shearman
2015-03-24 18:43 ` Vivek Venkatraman
2015-03-20 15:42 ` [PATCH net-next v2 3/5] mpls: Differentiate implicit-null and unlabeled neighbours Robert Shearman
2015-03-22 19:49 ` Eric W. Biederman
2015-03-22 21:06 ` Eric W. Biederman
2015-03-23 11:47 ` Robert Shearman
2015-03-20 15:42 ` [PATCH net-next v2 4/5] mpls: Per-device enabling of packet forwarding Robert Shearman
2015-03-22 20:02 ` Eric W. Biederman
2015-03-22 20:34 ` Eric W. Biederman
2015-03-23 13:42 ` Robert Shearman
2015-03-23 13:10 ` Robert Shearman
2015-03-20 15:42 ` [PATCH net-next v2 5/5] mpls: Allow payload type to be associated with label routes Robert Shearman
2015-03-22 20:56 ` Eric W. Biederman
2015-03-23 14:02 ` Robert Shearman
2015-03-30 18:15 ` [PATCH net-next v3 0/4] mpls: Behaviour-changing improvements Robert Shearman
2015-03-30 18:15 ` [PATCH net-next v3 1/4] mpls: Use definition for reserved label checks Robert Shearman
2015-03-30 18:15 ` [PATCH net-next v3 2/4] mpls: Differentiate implicit-null and unlabeled neighbours Robert Shearman
2015-04-07 16:56 ` Eric W. Biederman
2015-04-08 17:08 ` Robert Shearman
2015-03-30 18:15 ` [PATCH net-next v3 3/4] mpls: Per-device enabling of packet input Robert Shearman
2015-04-07 17:02 ` Eric W. Biederman
2015-04-08 14:29 ` Robert Shearman
2015-04-08 14:44 ` Eric W. Biederman
2015-03-30 18:15 ` [PATCH net-next v3 4/4] mpls: Allow payload type to be associated with label routes Robert Shearman
2015-04-07 17:19 ` Eric W. Biederman
2015-04-08 14:03 ` Robert Shearman
2015-04-01 19:30 ` [PATCH net-next v3 0/4] mpls: Behaviour-changing improvements David Miller
2015-04-01 21:14 ` Eric W. Biederman
2015-04-01 23:49 ` Robert Shearman
2015-04-06 20:02 ` David Miller
2015-04-14 22:44 ` [PATCH net-next v4 0/6] " Robert Shearman
2015-04-14 22:44 ` [PATCH net-next v4 1/6] mpls: Use definition for reserved label checks Robert Shearman
2015-04-14 22:44 ` [PATCH net-next v4 2/6] mpls: Per-device MPLS state Robert Shearman
2015-04-14 22:45 ` [PATCH net-next v4 3/6] mpls: Per-device enabling of packet input Robert Shearman
2015-04-14 22:45 ` [PATCH net-next v4 4/6] mpls: Allow payload type to be associated with label routes Robert Shearman
2015-04-14 22:45 ` [PATCH net-next v4 5/6] mpls: Differentiate implicit-null and unlabeled neighbours Robert Shearman
2015-04-14 22:45 ` [PATCH net-next v4 6/6] mpls: Prevent use of implicit NULL label as outgoing label Robert Shearman
2015-04-21 20:34 ` [PATCH 0/3] mpls: ABI changes for security and correctness Robert Shearman
2015-04-21 20:34 ` [PATCH 1/3] mpls: Per-device MPLS state Robert Shearman
2015-04-21 20:34 ` [PATCH 2/3] mpls: Per-device enabling of packet input Robert Shearman
2015-04-21 20:34 ` [PATCH 3/3] mpls: Prevent use of implicit NULL label as outgoing label Robert Shearman
2015-04-22 0:29 ` [PATCH 0/3] mpls: ABI changes for security and correctness Eric W. Biederman
2015-04-22 2:12 ` David Miller
2015-04-22 10:10 ` Robert Shearman
2015-04-22 10:14 ` [PATCH v2 " Robert Shearman
2015-04-22 10:14 ` [PATCH v2 1/3] mpls: Per-device MPLS state Robert Shearman
2015-04-22 15:25 ` Eric W. Biederman [this message]
2015-04-22 10:14 ` [PATCH v2 2/3] mpls: Per-device enabling of packet input Robert Shearman
2015-04-22 16:27 ` Eric W. Biederman
2015-04-22 10:14 ` [PATCH v2 3/3] mpls: Prevent use of implicit NULL label as outgoing label Robert Shearman
2015-04-22 16:32 ` Eric W. Biederman
2015-04-22 16:47 ` [PATCH v2 0/3] mpls: ABI changes for security and correctness Eric W. Biederman
2015-04-22 18:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ft4mbgj.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rshearma@brocade$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox