From: Rusty Russell <rusty@rustcorp•com.au>
To: Jason Wang <jasowang@redhat•com>,
mst@redhat•com, virtualization@lists•linux-foundation.org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Cc: Jason Wang <jasowang@redhat•com>, Sasha Levin <sasha.levin@oracle•com>
Subject: Re: [PATCH net] virtio-net: fix the race between channels setting and refill
Date: Thu, 04 Jul 2013 11:48:31 +0930 [thread overview]
Message-ID: <877gh7f4p4.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1372853752-41889-1-git-send-email-jasowang@redhat.com>
Jason Wang <jasowang@redhat•com> writes:
> Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx queues
> which are being used) tries to refill on demand when changing the number of
> channels by call try_refill_recv() directly, this may race:
>
> - the refill work who may do the refill in the same time
> - the try_refill_recv() called in bh since napi was not disabled
>
> Which may led guest complain during setting channels:
>
> virtio_net virtio0: input.1:id 0 is not a head!
>
> Solve this issue by scheduling a refill work which can guarantee the
> serialization of refill.
>
> Cc: Sasha Levin <sasha.levin@oracle•com>
> Cc: Rusty Russell <rusty@rustcorp•com.au>
> Cc: Michael S. Tsirkin <mst@redhat•com>
> Signed-off-by: Jason Wang <jasowang@redhat•com>
Thanks.
Applied,
Rusty.
next prev parent reply other threads:[~2013-07-04 2:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 12:15 [PATCH net] virtio-net: fix the race between channels setting and refill Jason Wang
2013-07-03 23:59 ` David Miller
2013-07-04 0:56 ` Asias He
2013-07-04 2:18 ` Rusty Russell [this message]
2013-07-04 8:23 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gh7f4p4.fsf@rustcorp.com.au \
--to=rusty@rustcorp$(echo .)com.au \
--cc=jasowang@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sasha.levin@oracle$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox