From: ebiederm@xmission•com (Eric W. Biederman)
To: Martin Mokrejs <mmokrejs@fold•natur.cuni.cz>
Cc: David Miller <davem@davemloft•net>,
vyasevich@gmail•com, netdev@vger•kernel.org,
linux-sctp@vger•kernel.org
Subject: Re: [PATCH] SCTP: Free the per-net sysctl table on net exit. v2
Date: Mon, 28 Jan 2013 07:47:12 -0800 [thread overview]
Message-ID: <877gmxtim7.fsf@xmission.com> (raw)
In-Reply-To: <510637D8.9000305@fold.natur.cuni.cz> (Martin Mokrejs's message of "Mon, 28 Jan 2013 09:33:28 +0100")
Martin Mokrejs <mmokrejs@fold•natur.cuni.cz> writes:
> David Miller wrote:
>> From: ebiederm@xmission•com (Eric W. Biederman)
>> Date: Sun, 27 Jan 2013 19:25:11 -0800
>>
>>> The typo is fixed in the patch this time in addition to my test
>>> tree.
>>
>> Applied, thanks for fixing this up Eric.
>
> I did check now how come that I patched my 3.7.4 on Jan 24. Looks like
> -head or -next has different namings. For me, the original patch applied
> fine. So far I haven't hit the memleak although it happened only once to me
> before the patch.
The problem isn't that the patch doesn't apply the problem is that the
patch did not build. The naming has not changed in the git history.
> But probably I can confirm say Tested-by:.
>
> #
> -rw-r--r-- 1 root root 8435 Jan 24 17:12 /usr/src/linux-3.7.4/net/sctp/sysctl.c
> -rw-rw-r-- 1 root root 8347 Jan 21 20:45 /usr/src/linux-3.7.4/net/sctp/sysctl.c.orig
> # ls -la /usr/src/linux-3.7.4/net/sctp/sysctl.o
> -rw-r--r-- 1 root root 246144 Jan 21 22:37 /usr/src/linux-3.7.4/net/sctp/sysctl.o
> # ls -la /usr/src/linux-3.7.4/arch/x86/boot/bzImage
> -rw-r--r-- 1 root root 3794592 Jan 21 22:45 /usr/src/linux-3.7.4/arch/x86/boot/bzImage
> #
It doesn't look look like you rebuilt anything after you applied the
changes to net/sctp/sysctl.c. sysctl.o and bzImage are both 3 days older.
Eric
next prev parent reply other threads:[~2013-01-28 15:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51004F2D.9000405@fold.natur.cuni.cz>
2013-01-24 16:02 ` [PATCH] SCTP: Free the per-net sysctl table on net exit Vlad Yasevich
2013-01-24 16:44 ` Neil Horman
2013-01-24 22:14 ` Eric W. Biederman
2013-01-28 0:35 ` David Miller
2013-01-28 1:58 ` Eric W. Biederman
2013-01-28 3:25 ` [PATCH] SCTP: Free the per-net sysctl table on net exit. v2 Eric W. Biederman
2013-01-28 5:11 ` David Miller
2013-01-28 8:33 ` Martin Mokrejs
2013-01-28 15:47 ` Eric W. Biederman [this message]
2013-01-28 21:17 ` Martin Mokrejs
2013-01-28 21:25 ` Martin Mokrejs
2013-01-29 0:20 ` Eric W. Biederman
2013-03-05 9:05 ` Martin Mokrejs
2013-03-05 19:32 ` David Miller
2013-03-05 21:04 ` Martin Mokrejs
2013-03-05 21:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gmxtim7.fsf@xmission.com \
--to=ebiederm@xmission$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=mmokrejs@fold$(echo .)natur.cuni.cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox