Subject: Re: [PATCH] TCPCT-1: adding a sysctl

From: Andi Kleen <[email-masked]>
Date: Fri, 02 Oct 2009 23:06:30 +0200

William Allen Simpson <[email-masked]> writes:
>
> Any suggestions for improvement?  Or general approval?

The patch seems incomplete, can't find callers for most of the new functions.

In general cookies fell a bit out of favour because they don't support window
scaling etc.  But you don't seem to fix that by putting that data into
the new option.

My immediate gut reaction is that it will be likely challenging to 
traverse many packet filters (which often have a tendency to drop
anything they don't know) with this option on. That is also what killed
ECN.

-Andi

-- 
[email-masked] -- Speaking for myself only.