Subject: Re: [RFC v2: Patch 1/3] net: hand off skb list to other cpu to submit to upper layer

From: Andi Kleen <[email-masked]>
Date: Wed, 11 Mar 2009 12:13:58 +0100

"Zhang, Yanmin" <[email-masked]> writes:

> I got some comments. Special thanks to ï»¿Stephen Hemminger for teaching me on
> what reorder is and some other comments. Also thank other guys who raised comments.

>
> v2 has some improvements.
> 1) Add new sysfs interface /sys/class/net/ethXXX/rx_queueXXX/processing_cpu. Admin
> could use it to configure the binding between RX and cpu number. So it's convenient
> for drivers to use the new capability.

Seems very inconvenient to have to configure this by hand. How about
auto selecting one that shares the same LLC or somesuch? Passing
data to anything with the same LLC should be cheap enough.

BTW the standard idea to balance processing over multiple CPUs was to
use MSI-X to multiple CPUs. and just use the hash function on the
NIC. Have you considered this for forwarding too? The trick here would
be to try to avoid reordering inside streams as far as possible, but
since the NIC hash should work on flow basis that should be ok.

-Andi

-- 
[email-masked] -- Speaking for myself only.