From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Hangbin Liu <liuhangbin@gmail•com>, netdev@vger•kernel.org
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
Jesper Dangaard Brouer <hawk@kernel•org>,
John Fastabend <john.fastabend@gmail•com>,
Jiri Pirko <jiri@resnulli•us>,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
Lorenzo Bianconi <lorenzo@kernel•org>,
Andrii Nakryiko <andriin@fb•com>, Jussi Maki <joamaki@gmail•com>,
Jay Vosburgh <jv@jvosburgh•net>,
Andy Gospodarek <andy@greyhouse•net>,
Jonathan Corbet <corbet@lwn•net>,
Andrew Lunn <andrew+netdev@lunn•ch>,
linux-doc@vger•kernel.org, linux-kernel@vger•kernel.org,
bpf@vger•kernel.org, Hangbin Liu <liuhangbin@gmail•com>,
Nikolay Aleksandrov <razor@blackwall•org>
Subject: Re: [PATCHv2 net-next 2/3] bonding: use correct return value
Date: Thu, 17 Oct 2024 16:47:19 +0200 [thread overview]
Message-ID: <878qumzszs.fsf@toke.dk> (raw)
In-Reply-To: <20241017020638.6905-3-liuhangbin@gmail.com>
Hangbin Liu <liuhangbin@gmail•com> writes:
> When a slave already has an XDP program loaded, the correct return value
> should be -EEXIST instead of -EOPNOTSUPP.
>
> Fixes: 9e2ee5c7e7c3 ("net, bonding: Add XDP support to the bonding driver")
> Reviewed-by: Nikolay Aleksandrov <razor@blackwall•org>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail•com>
> ---
> drivers/net/bonding/bond_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index f0f76b6ac8be..6887a867fe8b 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -5699,7 +5699,7 @@ static int bond_xdp_set(struct net_device *dev, struct bpf_prog *prog,
> if (dev_xdp_prog_count(slave_dev) > 0) {
> SLAVE_NL_ERR(dev, slave_dev, extack,
> "Slave has XDP program loaded, please unload before enslaving");
> - err = -EOPNOTSUPP;
> + err = -EEXIST;
Hmm, this has been UAPI since kernel 5.15, so can we really change it
now? What's the purpose of changing it, anyway?
-Toke
next prev parent reply other threads:[~2024-10-17 14:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 2:06 [PATCHv2 net-next 0/3] Bonding: returns detailed error about XDP failures Hangbin Liu
2024-10-17 2:06 ` [PATCHv2 net-next 1/3] bonding: return detailed error when loading native XDP fails Hangbin Liu
2024-10-17 14:45 ` Toke Høiland-Jørgensen
2024-10-17 2:06 ` [PATCHv2 net-next 2/3] bonding: use correct return value Hangbin Liu
2024-10-17 14:47 ` Toke Høiland-Jørgensen [this message]
2024-10-18 0:46 ` Hangbin Liu
2024-10-18 9:41 ` Simon Horman
2024-10-18 11:29 ` Toke Høiland-Jørgensen
2024-10-18 14:21 ` Simon Horman
2024-10-19 0:51 ` Hangbin Liu
2024-10-19 9:19 ` Simon Horman
2024-10-17 2:06 ` [PATCHv2 net-next 3/3] Documentation: bonding: add XDP support explanation Hangbin Liu
2024-10-17 8:42 ` Nikolay Aleksandrov
2024-10-17 8:40 ` [PATCHv2 net-next 0/3] Bonding: returns detailed error about XDP failures Nikolay Aleksandrov
2024-10-17 9:26 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qumzszs.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andriin@fb$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=ast@kernel$(echo .)org \
--cc=bigeasy@linutronix$(echo .)de \
--cc=bpf@vger$(echo .)kernel.org \
--cc=corbet@lwn$(echo .)net \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=jiri@resnulli$(echo .)us \
--cc=joamaki@gmail$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jv@jvosburgh$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=liuhangbin@gmail$(echo .)com \
--cc=lorenzo@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox