From: Petr Machata <petrm@nvidia•com>
To: <Daniel.Machon@microchip•com>
Cc: <petrm@nvidia•com>, <netdev@vger•kernel.org>,
<davem@davemloft•net>, <maxime.chevallier@bootlin•com>,
<thomas.petazzoni@bootlin•com>, <edumazet@google•com>,
<kuba@kernel•org>, <pabeni@redhat•com>,
<Lars.Povlsen@microchip•com>, <Steen.Hegelund@microchip•com>,
<UNGLinuxDriver@microchip•com>, <joe@perches•com>,
<linux@armlinux•org.uk>, <Horatiu.Vultur@microchip•com>,
<Julia.Lawall@inria•fr>, <vladimir.oltean@nxp•com>,
<linux-kernel@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH net-next v2 4/6] net: microchip: sparx5: add support for apptrust
Date: Mon, 3 Oct 2022 11:34:59 +0200 [thread overview]
Message-ID: <878rlxxn9t.fsf@nvidia.com> (raw)
In-Reply-To: <Yzqc85mqkuakokCE@DEN-LT-70577>
<Daniel.Machon@microchip•com> writes:
>> >> > Make use of set/getapptrust() to implement per-selector trust and trust
>> >> > order.
>> >> >
>> >> > Signed-off-by: Daniel Machon <daniel.machon@microchip•com>
>> >> > ---
>> >> > .../ethernet/microchip/sparx5/sparx5_dcb.c | 116 ++++++++++++++++++
>> >> > .../ethernet/microchip/sparx5/sparx5_main.h | 3 +
>> >> > .../ethernet/microchip/sparx5/sparx5_port.c | 4 +-
>> >> > .../ethernet/microchip/sparx5/sparx5_port.h | 2 +
>> >> > .../ethernet/microchip/sparx5/sparx5_qos.c | 4 +
>> >> > 5 files changed, 127 insertions(+), 2 deletions(-)
>> >> >
>> >> > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c b/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
>> >> > index db17c124dac8..10aeb422b1ae 100644
>> >> > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
>> >> > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
>> >> > @@ -8,6 +8,22 @@
>> >> >
>> >> > #include "sparx5_port.h"
>> >> >
>> >> > +static const struct sparx5_dcb_apptrust {
>> >> > + u8 selectors[256];
>> >> > + int nselectors;
>> >> > + char *names;
>> >>
>> >> I think this should be just "name".
>> >
>> > I dont think so. This is a str representation of all the selector values.
>> > "names" makes more sense to me.
>>
>> But it just points to one name, doesn't it? The name of this apptrust
>> policy...
>
> It points to a str of space-separated selector names. I inteded it to
> be a str repr. of the selector values, and not a str identifier of the
> apptrust policy.
Ah, that's what you mean. Sure, NP :)
next prev parent reply other threads:[~2022-10-03 9:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 18:52 [PATCH net-next v2 0/6] Add new PCP and APPTRUST attributes to dcbnl Daniel Machon
2022-09-29 18:52 ` [PATCH net-next v2 1/6] net: dcb: add new pcp selector to app object Daniel Machon
2022-09-30 12:20 ` Petr Machata
2022-09-30 15:41 ` Petr Machata
2022-10-01 0:54 ` Jakub Kicinski
2022-10-03 7:52 ` Petr Machata
2022-10-03 16:25 ` Jakub Kicinski
2022-10-03 21:59 ` Daniel.Machon
2022-10-03 23:34 ` Jakub Kicinski
2022-10-04 10:56 ` Petr Machata
2022-10-04 10:20 ` Petr Machata
2022-10-04 10:52 ` Petr Machata
2022-10-04 19:51 ` Jakub Kicinski
2022-10-03 6:48 ` Daniel.Machon
2022-10-03 8:22 ` Petr Machata
2022-10-03 9:33 ` Daniel.Machon
2022-10-05 10:09 ` Petr Machata
2022-09-29 18:52 ` [PATCH net-next v2 2/6] net: dcb: add new apptrust attribute Daniel Machon
2022-09-30 13:03 ` Petr Machata
2022-09-29 18:52 ` [PATCH net-next v2 3/6] net: microchip: sparx5: add support for offloading pcp table Daniel Machon
2022-09-30 20:44 ` kernel test robot
2022-09-29 18:52 ` [PATCH net-next v2 4/6] net: microchip: sparx5: add support for apptrust Daniel Machon
2022-09-30 15:49 ` Petr Machata
2022-10-03 6:52 ` Daniel.Machon
2022-10-03 8:01 ` Petr Machata
2022-10-03 8:17 ` Daniel.Machon
2022-10-03 9:34 ` Petr Machata [this message]
2022-09-29 18:52 ` [PATCH net-next v2 5/6] net: microchip: sparx5: add support for offloading dscp table Daniel Machon
2022-09-30 23:23 ` kernel test robot
2022-09-29 18:52 ` [PATCH net-next v2 6/6] net: microchip: sparx5: add support for offloading default prio Daniel Machon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rlxxn9t.fsf@nvidia.com \
--to=petrm@nvidia$(echo .)com \
--cc=Daniel.Machon@microchip$(echo .)com \
--cc=Horatiu.Vultur@microchip$(echo .)com \
--cc=Julia.Lawall@inria$(echo .)fr \
--cc=Lars.Povlsen@microchip$(echo .)com \
--cc=Steen.Hegelund@microchip$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox