Subject: Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: use mv88e6185_g1_vtu_getnext() for the 6250

From: Tobias Waldekranz <[email-masked]>
Date: Sat, 16 Jan 2021 13:22:49 +0100

On Sat, Jan 16, 2021 at 03:39, Rasmus Villemoes <[email-masked]> wrote:
> mv88e6250_g1_vtu_getnext is almost identical to
> mv88e6185_g1_vtu_getnext, except for the 6250 only having 64 databases
> instead of 256. We can reduce code duplication by simply masking off
> the extra two garbage bits when assembling the fid from VTU op [3:0]
> and [11:8].
>
> Signed-off-by: Rasmus Villemoes <[email-masked]>

We might also want to give mv88e6250_g1_vtu_loadpurge the same
treatment.

Reviewed-by: Tobias Waldekranz <[email-masked]>
Tested-by: Tobias Waldekranz <[email-masked]>