From: Kalle Valo <kvalo@codeaurora•org>
To: Larry Finger <Larry.Finger@lwfinger•net>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital•se>,
Brett Rudley <brudley@broadcom•com>,
Arend van Spriel <arend@broadcom•com>,
Hante Meuleman <meuleman@broadcom•com>,
Fabian Frederick <fabf@skynet•be>,
linux-wireless@vger•kernel.org, brcm80211-dev-list@broadcom•com,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] brcm80211: brcmsmac: dma: Remove some unused functions
Date: Mon, 05 Jan 2015 12:34:27 +0200 [thread overview]
Message-ID: <878uhh3498.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <54A8DBF4.4050202@lwfinger.net> (Larry Finger's message of "Sun, 04 Jan 2015 00:21:40 -0600")
Larry Finger <Larry.Finger@lwfinger•net> writes:
> On 01/03/2015 06:47 PM, Rickard Strandqvist wrote:
>> Removes some functions that are not used anywhere:
>> dma_txflush() dma_txsuspended()
>>
>> This was partially found by using a static code analysis program called cppcheck.
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital•se>
>> ---
>> drivers/net/wireless/brcm80211/brcmsmac/dma.c | 19 -------------------
>> drivers/net/wireless/brcm80211/brcmsmac/dma.h | 2 --
>> 2 files changed, 21 deletions(-)
>
> Just because file dma.c is involved, it does not need to be, nor
> should it be in the subject line. You could specify the driver names
> in the file tree after wireless. In this instance, one possible
> subject would be "brcm80211: brcmsmac: Remove some unused functions".
> On the other hand, if you look at "git log" to see past patches, the
> driver maintainers even leave off the brcm80211 part, thus to match
> them, the subject should be "brcmsmac: Remove some unused functions".
This is a handy way to check what kind of format you should use:
$ git log --oneline --no-merges drivers/net/wireless/brcm80211/brcmsmac/dma.c | head
a38a9ef1c064 brcm80211: use container_of to resolve dma_info from dma_pub
67d0cf50bd32 brcmsmac: Fix WARNING caused by lack of calls to dma_mapping_error()
55cec505559d brcmsmac: Fix possible NULL pointer dereference in _dma_ctrlflags()
9242c7261b8c brcmsmac: Remove some noisy and uninformative debug messages
0c9a0a1dd145 brcmsmac: Add tracepoint for AMPDU session information
90123e045cac brcmsmac: Add brcms_dbg_dma() debug macro
b05618deb4ac brcmsmac: Use correct descriptor count when calculating next rx descriptor
e041f65d5f00 brcmsmac: Remove internal tx queue
05f8a6160491 brcmsmac: Add helper function for updating txavail count
ec5ab1dd73a4 brcmsmac: fix DMA on SoCs
> As was suggested earlier, you need to look at the precedents. Keeping
> a uniform method of patch naming helps when looking for patches in the
> git log.
Yeah, and also having clean[1] patch titles makes working with patchwork
so much easier and hence me happier :)
[1] clean patch title == short, clear and unique
--
Kalle Valo
prev parent reply other threads:[~2015-01-05 10:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 0:47 [PATCH] brcm80211: brcmsmac: dma: Remove some unused functions Rickard Strandqvist
[not found] ` <1420332469-5907-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
2015-01-04 6:21 ` Larry Finger
[not found] ` <54A8DBF4.4050202-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2015-01-04 12:43 ` Rickard Strandqvist
2015-01-05 10:49 ` Kalle Valo
2015-01-05 11:06 ` Arend van Spriel
2015-01-06 23:33 ` Rickard Strandqvist
2015-01-07 6:29 ` Julia Lawall
2015-01-07 8:58 ` Arend van Spriel
[not found] ` <54ACF523.2030706-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-01-09 17:58 ` Rickard Strandqvist
2015-01-07 8:57 ` Arend van Spriel
2015-01-05 10:34 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uhh3498.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora$(echo .)org \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=arend@broadcom$(echo .)com \
--cc=brcm80211-dev-list@broadcom$(echo .)com \
--cc=brudley@broadcom$(echo .)com \
--cc=fabf@skynet$(echo .)be \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=meuleman@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rickard_strandqvist@spectrumdigital$(echo .)se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox